Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

GUVNOR-2088 Adding logic to automatically publish to configured reposit... #112

Closed
wants to merge 1 commit into from

Conversation

joewhite101
Copy link

GUVNOR-2088 Adding logic to automatically publish to configured repositories in the settings.xml so that the build and deploy from the WB matches mvn behavior

…itories in the settings.xml so that the build and deploy from the WB matches mvn behavior
@manstis
Copy link
Member

manstis commented Mar 24, 2014

Thanks Joe.

67a1dc9

@manstis manstis closed this Mar 24, 2014

}catch(DeploymentException de){
throw new RuntimeException( de );
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the different length of indentation in the above code, it seems the code is usesing TABs. I guess the https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/blob/master/README.md does not strictly forbids it, but for the sake of consistency it would be better to use spaces.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are correct.

The README does advise to configure both Eclipse and IDEA to use spaces
instead of tabs.

Fortunately I did not blindly merge the pull requests and hence the
committed code contains spaces.

On 24 March 2014 09:04, Petr Široký notifications@github.com wrote:

In
guvnor-m2repo-editor/guvnor-m2repo-editor-backend/src/main/java/org/guvnor/m2repo/backend/server/GuvnorM2Repository.java:

  •                                           .addArtifact( jarArtifact )
    
  •                                           .addArtifact( pomXMLArtifact )
    
  •                                           .setRepository( remoteRepo );
    
  •                                   Aether.getAether().getSystem().deploy( Aether.getAether().getSession(),settingsRequest );
    
  •                               }
    
  •                           }
    
  •                       }
    
  •                   }
    
  •               }
    
  •       }
    
  •    }catch(DeploymentException de){
    
  •       throw new RuntimeException( de );
    
  •    }
    
    }

Looking at the different length of indentation in the above code, it seems
the code is usesing TABs. I guess the
https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/blob/master/README.mddoes not strictly forbids it, but for the sake of consistency it would be
better to use spaces.


Reply to this email directly or view it on GitHubhttps://github.com//pull/112/files#r10875968
.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, thanks for the info @manstis. Sorry, I should have looked at the actual commit that ended up in the repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants