Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document that sqlbuilder is mysql-only #33

Closed
joeshaw opened this issue Jul 3, 2014 · 3 comments
Closed

document that sqlbuilder is mysql-only #33

joeshaw opened this issue Jul 3, 2014 · 3 comments

Comments

@joeshaw
Copy link

joeshaw commented Jul 3, 2014

Other than a couple of passing references in column.go and doc.go, it's not clear that sqlbuilder is meant to be run against mysql. Postgres barfs at least on the backticks for quoting. I have not tested it against sqlite.

It would be good to make this very clear in the package docs and README at a minimum. Do you have plans or want to support additional SQL flavors in the future?

@pattyshack
Copy link
Contributor

We are running thousands of mysql boxes in production. It's unlikely that we'll switch to other sql variant at this point (except maybe webscale).

I'll update the document to clarify that sqlbuilder currently only works for mysql.

You're welcome to submit a patch to support other sql flavors. Perhaps add SerializeSqlWithOptions(buffer, options) to the Clause interface and override the default behavior for column serialization.

@pattyshack
Copy link
Contributor

add comment in #34 (looks like my vm's clock is all messed up)

@joeshaw
Copy link
Author

joeshaw commented Jul 3, 2014

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants