Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardinality bug? #47

Closed
andy61i opened this issue Jul 31, 2014 · 2 comments
Closed

cardinality bug? #47

andy61i opened this issue Jul 31, 2014 · 2 comments

Comments

@andy61i
Copy link

andy61i commented Jul 31, 2014

https://dl.dropboxusercontent.com/u/209/zxcvbn/test/index.html
temppass22 cardinality is 69
should not it be 36 (lower case + digits = 26+10)?

@pyramids
Copy link

I'm working on a fork where I already fixed this to what you expect---and I still consider that a bug. Only "22" is counted for its brute force entropy, and that has a cardinality of 10 at most (and arguably only 1).

@lowe
Copy link
Collaborator

lowe commented Sep 24, 2015

This bug was fixed long ago and I forgot to close this issue, apologies and thanks for reporting.

@lowe lowe closed this as completed Sep 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants