Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit 5407bc2 broke backwards compatibility for directly-loaded client-side API #82

Closed
ericyhwang opened this issue Jul 14, 2015 · 2 comments

Comments

@ericyhwang
Copy link

Previously, after loading the zxcvbn.js script directly (either synchronously or asynchronously), you'd call it withwindow.zxcvbn(password).

After commit 5407bc2, you have to do window.zxcvbn.zxcvbn(password), which is a backwards-incompatible change. If that was intentional, you'll want to publish a new major revision instead of a new patch revision as you did.

@lowe
Copy link
Collaborator

lowe commented Jul 14, 2015

This is a bug, thanks for catching

@lowe lowe closed this as completed in 4190f16 Jul 14, 2015
@ericyhwang
Copy link
Author

Thanks for the quick fix! (And for getting it officially published to npm!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants