Improve AuthFactoryProvider #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are cosmetic changes, but I hope they are useful and make the codebase cleaner. |
|
|
||
| /** | ||
| * Value factory provider supporting the {@link Principal} injection |
|
Besides the one nitpick, this looks great. Thanks |
* Make sure users pass the type inherited from `Principal` * Remove unchecked cast warnings * Remove unnecessary static class `AuthValueFactory`, which could be replaced by an anonymous class. * Make `PrincipalClassProvider` a holder class, rather then an interface. Doing so, we don't create a new anonymous class in `Binder`. * Documentation and style improvements.
|
Ok, thanks for feedback. Pushed a new version, let me know if it's good enough. |
|
LGTM!, waiting for Travis to finish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Principal.AuthValueFactory, which could be replaced by an anonymous class.PrincipalClassProvidera holder class, rather then an interface. Doing so, we don't create a new anonymous class inBinder.