New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additivity setting to LoggerConfiguration #1215

Merged
merged 1 commit into from Aug 13, 2015

Conversation

Projects
None yet
3 participants
@smcwhtdtmc

smcwhtdtmc commented Aug 12, 2015

This is related to dropwizard#868 and 7ab73cd

With additive=true (the default), a logger writes to its appender -and- any appenders hierarchically above it, including the root logger. For true redirection as described in issue 868, we need to be able to set additive=false so a logger writes to its appender only.

@lehcim

This comment has been minimized.

Show comment
Hide comment
@lehcim

lehcim Aug 13, 2015

Contributor

Last night I was wondering how to configure Dropwizard logging with different file appenders and additivity setting. Today morning I'm reading your PR ...
Thank you very much, you made my day!

Contributor

lehcim commented Aug 13, 2015

Last night I was wondering how to configure Dropwizard logging with different file appenders and additivity setting. Today morning I'm reading your PR ...
Thank you very much, you made my day!

@joschi

This comment has been minimized.

Show comment
Hide comment
@joschi

joschi Aug 13, 2015

Member

LGTM. Thanks!

Member

joschi commented Aug 13, 2015

LGTM. Thanks!

@joschi joschi added the improvement label Aug 13, 2015

@joschi joschi added this to the 0.9.0 milestone Aug 13, 2015

joschi added a commit that referenced this pull request Aug 13, 2015

Merge pull request #1215 from smcwhtdtmc/master
Add additivity setting to LoggerConfiguration

@joschi joschi merged commit 7bbdb86 into dropwizard:master Aug 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment