Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log missing template at ERROR instead of DEBUG #1509

Merged
merged 2 commits into from Apr 5, 2016
Merged

Log missing template at ERROR instead of DEBUG #1509

merged 2 commits into from Apr 5, 2016

Conversation

jplock
Copy link
Member

@jplock jplock commented Apr 5, 2016

Fixes #1508

@jplock jplock added this to the 1.0.0 milestone Apr 5, 2016
jplock
jplock reviewed Apr 5, 2016
View reviewed changes
dropwizard-views/src/main/java/io/dropwizard/views/ViewMessageBodyWriter.java
@@ -35,7 +35,6 @@
"</html>";

@Context
@SuppressWarnings("UnusedDeclaration")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eclipse was telling me this was no longer required, so I removed it.

@nickbabcock
Copy link
Contributor

This logging statement triggers for all template errors (ie compilation errors), not just missing templates, no? Just clarifying.

I thought I originally had a reason for writing to debug instead of error back in #1178, but I can't recall. It may have been because when an entity fails validations, it is (was?) logged under debug, similarly, if a template fails due to user input (is this even possible?) it should be debug logged to prevent log spam. So a couple of questions to ponder before merging that I may not have answered back in #1178

Don't forget to update the documentation, as it states that it will be logged under debug mode!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.873% when pulling a20532b on jplock:jp-gh1508 into 295b675 on dropwizard:master.

@jplock
Copy link
Member Author

jplock commented Apr 5, 2016

@nickbabcock thanks for catching the documentation issue. To answer your questions, I honestly have no idea. I personally don't use any of the views functionality so I'll have to play around with the various scenarios you described to see how this impacts things. @lennartkoopmann's recommendation made sense to me and I couldn't see a reason why we'd want to log a missing template at the debug level.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.873% when pulling 65629f6 on jplock:jp-gh1508 into 295b675 on dropwizard:master.

@joschi
Copy link
Member

joschi commented Apr 5, 2016

I agree on printing the log messages on ERROR level in this case. Otherwise people might too easily miss them.

LGTM. 👍

@joschi joschi self-assigned this Apr 5, 2016
@joschi joschi merged commit 7260af9 into dropwizard:master Apr 5, 2016
@jplock jplock deleted the jp-gh1508 branch April 6, 2016 20:49
joschi pushed a commit that referenced this pull request Apr 24, 2019
@dependabot @joschi
Bump jdbi3-bom from 3.7.1 to 3.8.0 (#2744)
cf953cb 
Bumps [jdbi3-bom](https://github.com/jdbi/jdbi) from 3.7.1 to 3.8.0.
<details>
<summary>Changelog</summary>

*Sourced from [jdbi3-bom's changelog](https://github.com/jdbi/jdbi/blob/master/RELEASE_NOTES.md).*

> [#3](https://github-redirect.dependabot.com/jdbi/jdbi/issues/3).8.0
> - New Features
>   - `RowViewMapper` lets you use higher level `RowView` in a `RowMapper`.
>   - `ResultIterable.first()` returns the first row. Throws an exception if there are zero rows.
>   - `ResultIterable.one()` returns the only row. Throws an exception if there are zero or multiple
>     rows.
>   - `ResultIterable.findOne()` returns an `Optional<T>` of the only row, or `Optional.empty()` if
>     there are zero rows, or the only row is `null`. Throws an exception if there are multiple rows.
> - Deprecated API
>   - `ResultIterable.findOnly()` is deprecated, in favor of the new method `ResultIterable.one()`.
</details>
<details>
<summary>Commits</summary>

- [`48e1f0d`](jdbi/jdbi@48e1f0d) [maven-release-plugin] prepare release v3.8.0
- [`985de45`](jdbi/jdbi@985de45) Merge pull request [#1511](https://github-redirect.dependabot.com/jdbi/jdbi/issues/1511) from jdbi/result-iterable-single-row-methods
- [`85e5639`](jdbi/jdbi@85e5639) Merge branch 'master' of github.com:jdbi/jdbi into result-iterable-single-row...
- [`4e8845c`](jdbi/jdbi@4e8845c) Add tests for one(), findOne(), and first(). Clarify possible return values i...
- [`7cd29fc`](jdbi/jdbi@7cd29fc) RowViewMapper: high-level map operation over RowView
- [`61d4a79`](jdbi/jdbi@61d4a79) Merge pull request [#1509](https://github-redirect.dependabot.com/jdbi/jdbi/issues/1509) from jdbi/register-many-immutables
- [`1e979e1`](jdbi/jdbi@1e979e1) Convenience methods for registering many Immutables types
- [`b25b728`](jdbi/jdbi@b25b728) Add new ResultIterable methods for single row results
- [`d96f48a`](jdbi/jdbi@d96f48a) Merge pull request [#1506](https://github-redirect.dependabot.com/jdbi/jdbi/issues/1506) from jdbi/column-name-docs
- [`b63c722`](jdbi/jdbi@b63c722) Add docs and tests for [@&#8203;ColumnName](https://github.com/ColumnName) annotation
- Additional commits viewable in [compare view](jdbi/jdbi@v3.7.1...v3.8.0)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=org.jdbi:jdbi3-bom&package-manager=maven&previous-version=3.7.1&new-version=3.8.0)](https://dependabot.com/compatibility-score.html?dependency-name=org.jdbi:jdbi3-bom&package-manager=maven&previous-version=3.7.1&new-version=3.8.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joschi joschi

Labels
improvement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jplock @nickbabcock @coveralls @joschi