-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more Java versions to Travis CI build matrix #2403
Conversation
See JEP 320: Remove the Java EE and CORBA Modules http://openjdk.java.net/jeps/320
@nickbabcock @joschi is this an issue with the
|
@jplock Javassist 3.23.0-GA doesn't support Java 8 anymore and Javassist 3.22.0-GA doesn't support Java 11. We'll either have to stop supporting Java 8 (EOL soon), not support Java 11 (released soon), or rewrite the functionality with a different library (e. g. Byte Buddy). I think I'll give Byte Buddy a try if I have a few minutes to spare. |
@joschi maybe when the next release comes out containing jboss-javassist/javassist#204, the tests will work again on JDK8. That puts us in a tricky position. We should support the latest LTS release (JDK11), but I'm not sure we should lose JDK8 support in DW 2.0.0 or not yet. |
<artifactId>javax.activation-api</artifactId> | ||
<version>1.2.0</version> | ||
<scope>runtime</scope> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does adding the two dependencies above mean that Dropwizard applications will no longer need --add-modules java.xml.bind
on Java 9+? Right now I need to manually include that option when running on Java 9
(Or not since they are runtime
dependencies?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RohanNagar Yes, the additional command line parameters for java.xml.bind can be removed.
The pull request is done and ready to merge from my perspective. The AppVeyor build failed for unrelated reasons (address already in use in parallel tests). |
In order to cover the Java/JDK versions we want to support with Dropwizard with Travis CI, this pull request adds OpenJDK 8 through 11 (EA) to the Travis CI build matrix.
There were some minor changes in the Maven build, mostly adding build profiles for the respective Java/JDK versions.
The following issues are open until Java 11 is completely supported without hacks: