Ensure FileAppenderFactoryTest works within its temporary directories #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure these tests use the temporary directory provided by JUnit for their log files. Stop the appender before finishing the test so that open file handles won't upset Windows.
rhowe
force-pushed
the
fix-fileappenderfactorytest
branch
from
a533674
to
6e52571
Compare
Remove unnecessary exception declarations and switch to using assertThatExceptionOfType
arteam
approved these changes
Feb 7, 2021
|
Amazing, thank you! |
joschi
pushed a commit
that referenced
this pull request
Feb 12, 2021
…#3692) * Ensure FileAppenderFactoryTest works within its temporary directories Ensure these tests use the temporary directory provided by JUnit for their log files. Stop the appender before finishing the test so that open file handles won't upset Windows. * Do some small cleanups to dropwizard-logging FileAppenderFactoryTest Remove unnecessary exception declarations and switch to using assertThatExceptionOfType (cherry picked from commit c740abf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure these tests use the temporary directory provided by JUnit for their log files.
Stop the appender before finishing the test so that open file handles won't upset Windows.
Slip in a couple of cleanups whilst we're here.