Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal doesn´t show up in IE 10 #33

Closed
anselm-urban opened this issue May 14, 2013 · 6 comments
Closed

Modal doesn´t show up in IE 10 #33

anselm-urban opened this issue May 14, 2013 · 6 comments
Milestone

Comments

@anselm-urban
Copy link
Contributor

The modal on my website doesn´t show up in IE10!

Here´s my code:

<a href="#twitter" class="topButton call-modal" title="Show my Twitter feed"><span class="icon-twitter"></span></a>
<figure class="semantic-content" id="twitter" tabindex="-1" role="dialog" aria-hidden="true">
    <div class="modal-inner">
        <div class="modal-content"><a class="twitter-timeline" height="500" href="https://twitter.com/anselm_urban" data-widget-id="280297923747647489">@anselm_urban´s tweets</a></div>
    </div>
    <a href="#!" class="modal-close" data-dismiss="modal">×</a>
</figure>

Update: works with JS.

@drublic
Copy link
Owner

drublic commented May 14, 2013

Looks like the IE8 CSS hack influences IE9 and IE10 too.

// Internet Explorer 8
display: none\9;

&.is-active {
    display: block\9;
}

I will try to work around this and find a better solution.

@anselm-urban
Copy link
Contributor Author

Here you´ll find a hack for only influencing IE8: http://browserhacks.com/
You could do the following for IE8: @media \0screen {}

@anselmh
Copy link
Contributor

anselmh commented May 15, 2013

selector { 
    … 
    last-property: value\0/; 
}

should be enough.

@anselm-urban
Copy link
Contributor Author

According to http://browserhacks.com/#ie this also covers IE9!

@anselmh
Copy link
Contributor

anselmh commented May 15, 2013

Of course, sorry. Then you have to go the MQ way

@drublic
Copy link
Owner

drublic commented May 15, 2013

Found another solution. Please see commit message.
Thanks for the help and reporting this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants