Add support for docker context, changes required docker constraint #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
force-pushed
the
20211216_docker_context
branch
from
4eb080b
to
b1977a0
Compare
rfay
changed the title
rfay
force-pushed
the
20211216_docker_context
branch
from
e69d7c7
to
7368922
Compare
rfay
changed the title
rfay
force-pushed
the
20211216_docker_context
branch
from
7368922
to
b848d8c
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
The nice new way to specify a docker endpoint instead of complicated
$DOCKER_HOSTisdocker context.Unfortunately neither the fsouza/go-dockerclient (that we currently use) nor the docker https://github.com/moby/moby has direct support for this, it's all written into the docker cli AFAICT.
How this PR Solves The Problem:
Use
docker context inspectto find out the current context's endpoint, then use that for DOCKER_HOST (if DOCKER_HOST is not set).TODO:
Manual Testing Instructions:
Try it out with colima or another remote context
Automated Testing Overview:
Related Issue Link(s):
Release/Deployment notes:
This changes the docker constraint to 19.03.9 (oldest version I could find that supported contexts).
As a result, it needs to wait for ddev v1.19.0