New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do IsInternetActive() less often, and do it more efficiently, fixes #4131 #4134

Merged

rfay merged 1 commit into ddev:master from rfay:20220819_improve_internet_detection

Aug 22, 2022

Member

rfay commented Aug 20, 2022 •

edited

Loading

The Problem/Issue/Bug:

How this PR Solves The Problem:

Only do IsInternetActive on start/restart
Only test test.ddev.site (and always use that instead of a random url)

Manual Testing Instructions:

export DDEV_DEBUG=true

You should only see the check happen on ddev start and ddev restart

Automated Testing Overview:

Related Issue Link(s):

Release/Deployment notes:


          Do IsInternetActive() less often, and do it more efficiently, fixes d…

14efa2f

…dev#4131

github-actions bot commented Aug 20, 2022

Download the artifacts for this pull request:

rfay merged commit 16ada4c into ddev:master

rfay deleted the 20220819_improve_internet_detection branch

August 22, 2022 00:16

rfay mentioned this pull request

DDEV integration entered unknown state by timeout php-perfect/ddev-intellij-plugin#83

Open

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet