Respond to close instead of exit events #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I observed a race condition when observing the 'exit' instead of the 'close' event. Sometimes encryption would work, sometimes it wouldn't. Debugging showed that the 'exit' event is sometimes called before a 'data' event arrives. The Node.js documentation actually states such behavior: Event: 'exit' Note that the child process stdio streams might still be open. http://nodejs.org/api/child_process.html#child_process_event_exit Event: 'close' This event is emitted when the stdio streams of a child process have all terminated. This is distinct from 'exit', since multiple processes might share the same stdio streams. http://nodejs.org/api/child_process.html#child_process_event_close This commit switches from the 'exit' to 'close' events.
drudge
added a commit
that referenced
this pull request
Mar 17, 2014
Respond to close instead of exit events
|
Thanks @bripkens! Published to npm as 0.3.3. |
|
Wow, thank you very much @drudge for merging and releasing this so fast! |
| @@ -124,7 +124,7 @@ var GPG = { | |||
| fn.call(null, null, buffer); | |||
| }); | |||
|
|
|||
| gpg.stdin.end(str); | |||
| gpg.stdin.end(str, 'utf8'); | |||
There was a problem hiding this comment.
Was this a necessary change? Why only in this spot? There are other places where stdin.end() is called without this change.
There was a problem hiding this comment.
@bripkens see my comment above.
There was a problem hiding this comment.
This shouldn't have been necessary. The only intention was to change the event that is being listened to.
There was a problem hiding this comment.
Ok, I will revert that then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed a race condition when observing the 'exit' instead of
the 'close' event. Sometimes encryption would work, sometimes it
wouldn't. Debugging showed that the 'exit' event is sometimes
called before a 'data' event arrives.
The Node.js documentation actually states such behavior:
Event: 'exit'
Note that the child process stdio streams might still be open.
http://nodejs.org/api/child_process.html#child_process_event_exit
Event: 'close'
This event is emitted when the stdio streams of a child process
have all terminated. This is distinct from 'exit', since multiple
processes might share the same stdio streams.
http://nodejs.org/api/child_process.html#child_process_event_close
This commit switches from the 'exit' to 'close' events.