fix groupBy caching to work with renamed aggregators #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .setQuerySegmentSpec(SEG_SPEC) | ||
| .setDimFilter(DIM_FILTER) | ||
| .setGranularity(GRANULARITY) | ||
| .setDimensions(Arrays.<DimensionSpec>asList(new DefaultDimensionSpec("a", "a"))) |
There was a problem hiding this comment.
can we test with a different output name as well? It's unclear which one should be stored in the cache
nishantmonu51
force-pushed
the
fix-groupby-caching
branch
from
f34aa77
to
072d3b4
Compare
| @@ -444,6 +448,7 @@ public String apply(DimensionSpec input) | |||
| + limitBytes.length | |||
| ) | |||
| .put(GROUPBY_QUERY) | |||
| .put(CACHE_STRATEGY_VER) | |||
There was a problem hiding this comment.
can we spell out version instead of using abbreviations?
|
👍 |
Issue - while storing results in cache we store the event map which contains aggregator names mapped to values. Now when someone fire same query after renaming aggs, the cache key will be same but the event will contain metric values mapped to older names which leads to wrong results. Fix - modify cache to not store raw event but the actual list of values only. review comments + fix dimension renaming review comment
nishantmonu51
force-pushed
the
fix-groupby-caching
branch
from
072d3b4
to
184b12b
Compare
xvrl
added a commit
that referenced
this pull request
Jul 9, 2015
fix groupBy caching to work with renamed aggregators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - while storing results in cache we store the event map which
contains aggregator names mapped to values. Now when someone fire same
query after renaming aggs, the cache key will be same but the event
will contain metric values mapped to older names which leads to wrong
results.
Fix - modify cache to not store raw event but the actual list of values
only.