Remove locks from StupidPool #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| log.warn("Not closed! Object was[%s]. Allowing gc to prevent leak.", object); | ||
| } | ||
| super.finalize(); |
There was a problem hiding this comment.
I wonder why this wasn't there before?
There was a problem hiding this comment.
if we need to add it, it should probably be in a finalize block to ensure it gets run no matter what happens
There was a problem hiding this comment.
Object.finalize is a no-op in the basic source code. It seemed like a bad idea not to have it present though.
There was a problem hiding this comment.
Added in finally block
drcrallen
force-pushed
the
stupidPoolLockless
branch
from
ba5e6e4
to
7cc83d3
Compare
|
LGTM, some benchmarks or indication it resolved the issue you were seeing would be good though |
drcrallen
force-pushed
the
stupidPoolLockless
branch
from
7cc83d3
to
7fe8562
Compare
seoeun25
pushed a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Production systems spend a shocking amount of cpu time in StupidPool.close (on the order of 18%) this is an attempt to reduce that footprint.
Simply looking at the stupidpool stats:
Master: 1.308 ± 0.067 ops/us
This PR: 4.7~5.1 ops/us
This PR is harder to benchmark because it is bound by ObjectResourceHolder and the garbage created that way.
Master is slow enough not to hit that bound.