update indexing in the helper to use multiple persists and merge #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| catch (IndexSizeExceededException ex) { | ||
| File tmp = Files.createTempDir(); |
There was a problem hiding this comment.
The indexing tests are notoriously dirty about leaving files behind. Can this be reorchestrated to use a controlled TemporaryFolder @rule, either here or from the caller?
himanshug
force-pushed
the
update_agg_test_helper
branch
from
6fc5d61
to
178bfd5
Compare
|
👍 |
…e to catch further issues in aggregator implementations
himanshug
force-pushed
the
update_agg_test_helper
branch
from
178bfd5
to
5da58e4
Compare
|
+1 after squashing commits |
fjy
added a commit
that referenced
this pull request
Sep 14, 2015
update indexing in the helper to use multiple persists and merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this catches more issues with our sketch aggregator module implementation related to when intermediate persists happen while ingestion.