Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check for sortedness if we already know GenericIndexedWriter isn't sorted #1725

Merged

Conversation

drcrallen
Copy link
Contributor

The plumber's incremental persist can spend up to 20% of its time doing the compare if HLL aggs are used. This skips the compare if we already know the data isn't sorted.

@drcrallen drcrallen added this to the 0.8.2 milestone Sep 11, 2015
@fjy
Copy link
Contributor

fjy commented Sep 11, 2015

👍

1 similar comment
@gianm
Copy link
Contributor

gianm commented Sep 12, 2015

👍

@drcrallen drcrallen closed this Sep 12, 2015
@drcrallen drcrallen reopened this Sep 12, 2015
xvrl added a commit that referenced this pull request Sep 12, 2015
…bjectsSorted

Don't check for sortedness if we already know GenericIndexedWriter isn't sorted
@xvrl xvrl merged commit 43012d3 into apache:master Sep 12, 2015
@drcrallen drcrallen deleted the genericIndexedWriteOptimizationObjectsSorted branch September 14, 2015 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants