Try and make AnnouncerTest a bit more predictable #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,6 +60,7 @@ public void tearDown() | |||
| public void testSanity() throws Exception | |||
| { | |||
| curator.start(); | |||
| curator.blockUntilConnected(); | |||
There was a problem hiding this comment.
since this is unbounded blocking, can you add a timeout to this (and other) tests with @test ?
There was a problem hiding this comment.
Added timeout for tests which block until connected.
drcrallen
force-pushed
the
announcerTestTransactions
branch
from
dd28fb4
to
7d635a2
Compare
|
👍 |
himanshug
added a commit
that referenced
this pull request
Oct 2, 2015
Try and make AnnouncerTest a bit more predictable
seoeun25
pushed a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indentation changes make this look bigger than it is.