Fix ClientInfoResource #1801
Merged
Fix ClientInfoResource #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
👍 |
Fix ClientInfoResource so that it doesn't return empty list for overshadowed segments
guobingkun
force-pushed
the
clientInfoResource
branch
from
ac165b1
to
57c8e56
Compare
| { | ||
| Map<String, Object> actual = resource.getDatasource(dataSource, "1975/2050", null); | ||
| Map<String, ?> expected = ImmutableMap.of( | ||
| Map<String, Object> actual = resource.getDatasource(dataSource, "1975/2015", null); |
There was a problem hiding this comment.
any reason we are changing the interval on those tests?
There was a problem hiding this comment.
yeah.. Because I added some new segments in that interval, and still wanted to reuse this test case, so I shortened the interval. I added testGetDatasourceNonFullWithLargeInterval() in the end so that 1975/2050 is still tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ClientInfoResource so that it doesn't return empty list for overshadowed segments.