Fix broken KafkaEmitterConfig parsing #5201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a regression introduced in apache#4722 KafkaEmitterConfig property names have dot(.) in the name of properties and JsonConfigurator behavior was changed to not support that. Added a test and fixed parsing of properties that have dot(.) in property names
|
Just noticed this breaks ParametrizedUriEmitterConfig. |
|
@nishantmonu51 Does it will merge into Druid 0.12.0？ |
|
fixed test failures. |
jon-wei
approved these changes
Jan 3, 2018
|
@nishantmonu51 cool, can you backport this? |
jon-wei
pushed a commit
to jon-wei/druid
that referenced
this pull request
Jan 3, 2018
* Fix broken KafkaEmitterConfig parsing This was a regression introduced in apache#4722 KafkaEmitterConfig property names have dot(.) in the name of properties and JsonConfigurator behavior was changed to not support that. Added a test and fixed parsing of properties that have dot(.) in property names * Fix test failure
|
@nishantmonu51 I went ahead and made a backport for this |
jon-wei
added a commit
that referenced
this pull request
Jan 4, 2018
* Fix broken KafkaEmitterConfig parsing This was a regression introduced in #4722 KafkaEmitterConfig property names have dot(.) in the name of properties and JsonConfigurator behavior was changed to not support that. Added a test and fixed parsing of properties that have dot(.) in property names * Fix test failure
gianm
pushed a commit
that referenced
this pull request
Jan 9, 2018
* Fix broken KafkaEmitterConfig parsing This was a regression introduced in #4722 KafkaEmitterConfig property names have dot(.) in the name of properties and JsonConfigurator behavior was changed to not support that. Added a test and fixed parsing of properties that have dot(.) in property names * Fix test failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - #5198
This was a regression introduced in
#4722
KafkaEmitterConfig property names have dot(.) in the name of properties
and JsonConfigurator behavior was changed to not support that.
Added a test and fixed parsing of properties that have dot(.) in
property names