Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the route params through in the scaffold code #98

Closed
Dan-Ashdown opened this issue Jan 16, 2023 · 4 comments
Closed

Pass the route params through in the scaffold code #98

Dan-Ashdown opened this issue Jan 16, 2023 · 4 comments

Comments

@Dan-Ashdown
Copy link

Currently GET params do not get passed back, in my case I needed these for Views exposed filters.
@Dan-Ashdown
Copy link
Author

Patch to fix:

98-pass-route-params.txt

@fago
Copy link
Contributor

fago commented Jan 23, 2023

@Dan-Ashdown-FFT thx, that seems straight-forward and good to do by default. I checked and we also do this in our projects actually. So let's improve the scaffold code. Could you do a proper PR so we can get it merged?
The Github workflow is to fork the module in your own namespace then you can submit a PR from there.

@Dan-Ashdown Dan-Ashdown mentioned this issue Jan 23, 2023
Merged
@Dan-Ashdown
Copy link
Author

Thanks @fago created a PR #100

@fago
Copy link
Contributor

fago commented Jan 24, 2023

Merged :-)

@fago fago closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fago @Dan-Ashdown