Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.2.3 #280

Closed
9 tasks done
sylus opened this issue Apr 8, 2022 · 8 comments
Closed
9 tasks done

Release v4.2.3 #280

sylus opened this issue Apr 8, 2022 · 8 comments
Assignees

Comments

@sylus
Copy link
Member

sylus commented Apr 8, 2022

See the full release documentation for more detail.

  • All related projects (wxt_library and wxt_bootstrap) tagged and released on GitHub.com and Drupal.org
  • Version number selected
  • CHANGELOG.md updated
  • composer.json updated
  • Run version.sh for hook_updates and wxt contrib
  • CI build passes
  • Releases tagged along with correct version and pushed to GitHub.com and Drupal.org
  • WxT released on Drupal.org (https://github.com/drupalwxt/wxt/wiki/Release-process#release)
  • Add changelog information to published tag once CI is done
@sylus sylus self-assigned this Apr 8, 2022
@thomascraig
Copy link

FYI, getting an error running composer update on your latest bump to core 9.2.16 via last patch: Cannot apply patch https://www.drupal.org/files/issues/2019-10-11/Move_Seven_block_config_into_the_Seven_theme-2632132-42.patch

@sylus
Copy link
Member Author

sylus commented Apr 12, 2022

Hmm that is odd its applying for me in the CI and on my local.

https://github.com/drupalwxt/wxt/runs/5890871864?check_suite_focus=true#step:5:1059

@sylus
Copy link
Member Author

sylus commented Apr 12, 2022

  - Applying patches for drupal/core
    https://www.drupal.org/files/issues/postgresql_ssl_dsn-850600-3.patch (Enter drupal/core patch #850600 description here)
    https://www.drupal.org/files/issues/2021-06-29/D91x-1356276-656.patch (Enter drupal/core patch #1356276 description here)
    https://www.drupal.org/files/issues/2021-06-02/comment_form_redirect-2559833-87.patch (Enter drupal/core patch #2559833 description here)
    https://www.drupal.org/files/issues/2020-09-17/2630732-77.patch (Enter drupal/core patch #2630732 description here)
    https://www.drupal.org/files/issues/2679775-11-inline-labels.patch (2679775 - Fixes float issue with inline label fields (entity references on most cases).)
    https://www.drupal.org/files/issues/2020-06-22/2699157-38.drupal.Plugin-Lazy-loading-can-cause-usort-warning.patch (2699157 - Plugin Lazy loading can cause usort warning)
    https://www.drupal.org/files/issues/2020-01-09/regression-2715483-22.patch (Enter drupal/core patch #2715483 description here)
    https://www.drupal.org/files/issues/in_correct_order_and-2752443-1.patch (Enter drupal/core patch #2752443 description here)
    https://www.drupal.org/files/issues/2020-03-21/2759397-19-entityref_recursion.patch (2759397 - Patch EntityReferenceItemNormalizer to prevent recursion)
    https://www.drupal.org/files/issues/2021-03-19/taxonomy_translation_2765297_63.patch (Enter drupal/core patch #2765297 description here)
    https://www.drupal.org/files/issues/user_password-2816921-2.patch (Enter drupal/core patch #2816921 description here)
    https://www.drupal.org/files/issues/2020-07-13/D91x-self_closing_correct-2857273-13.patch (Enter drupal/core patch #2857273 description here)
    https://www.drupal.org/files/issues/systemmainblock_build-2885370-3.patch (Enter drupal/core patch #2885370 description here)
    https://www.drupal.org/files/issues/2893029-9.patch (Enter drupal/core patch #2893029 description here)
    https://www.drupal.org/files/issues/2021-06-07/2893407-47.patch (Enter drupal/core patch #2893407 description here)
    https://www.drupal.org/files/issues/2019-06-21/2907413-11.patch (Enter drupal/core patch #2907413 description here)
    https://www.drupal.org/files/issues/2021-09-07/2921627-68_3.patch (2921627 - WCAG required markers on forms)
    https://www.drupal.org/files/issues/2021-09-08/2922570-90.9.2.5.patch (Enter drupal/core patch #2922570 description here)
    https://www.drupal.org/files/issues/2019-01-18/2938129-pagetitle-11.patch (Enter drupal/core patch #2938129 description here)
    https://www.drupal.org/files/issues/2018-12-05/3017710-20.patch (Enter drupal/core patch #3017710 description here)
    https://www.drupal.org/files/issues/2021-11-02/3150294-74.patch (3150294 - New translations for moderated nodes are not created in the initial workflow state)
    https://www.drupal.org/files/issues/2021-05-17/3164210-11.patch (Enter drupal/core patch #3164210 description here)
    https://www.drupal.org/files/issues/2020-10-20/book-breadcrumb_title_xlate-3177182-3.patch (3177182 - Book title in breadcrumb not translated)
    https://www.drupal.org/files/issues/2021-01-31/3173808-9-Make-book-child-content-type-configura.patch (Enter drupal/core patch #3173808 description here)
    https://www.drupal.org/files/issues/2020-10-02/2546212-155.patch (Enter drupal/core patch #2546212 description here)
    https://www.drupal.org/files/issues/2021-08-20/3184667-38.patch (Enter drupal/core patch #3184667 description here)
    https://www.drupal.org/files/issues/2021-04-08/3207813-2.patch (Enter drupal/core patch #3207813 description here)
    https://www.drupal.org/files/issues/2021-12-22/drupal-core-9.2.x-li-role-separator-tag-linkGenerator-3236799-11.patch (Enter drupal/core patch #3236799 description here)
    https://www.drupal.org/files/issues/2019-10-11/Move_Seven_block_config_into_the_Seven_theme-2632132-42.patch (2632132 - Fix seven install)
    https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch (2869592 - Disabled update module shouldn't produce a status report warning)

Possibly to have more information what version of Composer, Patch, and OS are you running?

@thomascraig
Copy link

composer 2.1.5, Cannot apply patch 2632132 , MacOS Montery 12.3.1 - have 3 projects using the drupalwxt all failing on same patch

@sylus
Copy link
Member Author

sylus commented Apr 13, 2022

I'm currently running into an issue with patching, where patches created with git diff include renames which are not understood by patch.

You need GNU Patch >= 2.7. From their News page (https://savannah.gnu.org/forum/forum.php?forum_id=7361) about 2.7:

Support for most features of the "diff --git" format, including renames and copies, permission changes, and symlink diffs. Binary diffs are not supported yet; patch will complain and skip them.

@sylus
Copy link
Member Author

sylus commented Apr 13, 2022

@sylus
Copy link
Member Author

sylus commented Apr 13, 2022

Can you try @thomascraig :

brew install gpatch

@thomascraig
Copy link

@sylus the gpatch resolved the issue. thanks.

@sylus sylus closed this as completed Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants