Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parsing of Tokens Studio files #205

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Improve parsing of Tokens Studio files #205

merged 1 commit into from
Mar 5, 2024

Conversation

drwpow
Copy link
Collaborator

@drwpow drwpow commented Mar 3, 2024

Changes

Fixes #171, and also fixes several other Tokens Studio bugs in the process. While support isn’t perfect, it’s a lot better than it was, and will now be able to parse many more Tokens Studio exports that it would err out on before.

How to Review

  • Tests updated; tests should pass

Copy link

changeset-bot bot commented Mar 3, 2024

🦋 Changeset detected

Latest commit: 7d2afcc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cobalt-ui/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

cloudflare-workers-and-pages bot commented Mar 3, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7d2afcc
Status: ✅  Deploy successful!
Preview URL: https://b7487347.cobalt-ui.pages.dev
Branch Preview URL: https://fix-ts.cobalt-ui.pages.dev

View logs

@drwpow drwpow force-pushed the fix/ts branch 3 times, most recently from 4a1b3e0 to d865590 Compare March 5, 2024 00:13
@drwpow drwpow marked this pull request as ready for review March 5, 2024 00:13
packages/core/src/parse/tokens-studio.ts Dismissed Show dismissed Hide dismissed
@drwpow drwpow changed the title [WIP] Fix parsing bug with tokens studio format Improve parsing of Tokens Studio files Mar 5, 2024
@drwpow drwpow merged commit 5f39eb5 into main Mar 5, 2024
10 checks passed
@drwpow drwpow deleted the fix/ts branch March 5, 2024 00:20
@github-actions github-actions bot mentioned this pull request Mar 5, 2024
james-nash added a commit to james-nash/cobalt-ui that referenced this pull request Mar 5, 2024
drwpow pushed a commit that referenced this pull request Mar 5, 2024
* Fix empty groups causing parsing errors (#206)

* Added test for empty groups (#205)

* Add changeset (#206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible bug with parsing Token Studio file
1 participant