Uncaught error when body is undefined in request init

[jaredLunde]

Description

Uncaught TypeError: Cannot set property body of # which has only a getter

https://github.com/drwpow/openapi-typescript/blob/main/packages/openapi-fetch/src/index.js#L16-L20

Basically, body is a getter on the Request object and the linked code is trying to write to it. One work around could be to wrap it in a try/catch. Otherwise I think you'll have to ignore some properties in the request init

Reproduction

Add a body to the request init object in openapi-fetch@0.9.6 e.g. client.POST('/', {body:undefined}).

Happens in all major browsers AFAICT

Checklist

• I’m willing to open a PR (see CONTRIBUTING.md)

[FreeAoi]

Hello! I can't reproduce the bug with the information provided, could you please create a repository where we can test it or let me know if there is another detail when doing the reproduction?

[jaredLunde]

Perhaps it is related to Bun, Astro, or Vite in some way. I'm not 100% sure where the Request global is being set, but I had assumed it was the browser's. Unfortunately I can't figure out how to install Bun on StackBlitz to dig further into a repro. Regardless, there's clearly some incompatibility in the vast JS/TS ecosystem as a result of overwriting Request properties that are native to the Request object Finding some other means of adding them would probably be beneficial for that reason.

For example:

const nativeRequest = new Request()

class CustomRequest extends Request {
  constructor(input, init) {
    super(input, init);

    // add custom parameters
    for (const key in init) {
      if (!(key in nativeRequest)) {
        this[key] = init[key];
      }
    }
  }
}

Or

class CustomRequest extends Request {
  constructor(input, init) {
    super(input, init);

    // add custom parameters
    for (const key in init) {
      if (!(key in this)) {
        this[key] = init[key];
      }
    }
  }
}

[jaredLunde]

Since body can be undefined, I'm guessing the naive check agains !this["body"] in the CustomRequest object is returning a false positive, while key in this would not return a false positive.

[FreeAoi]

I will take a look on this and if its necessary I will make a PR to fix it

[jaredLunde]

Oh wow, I'm so sorry. I have a repro: https://stackblitz.com/edit/vitejs-vite-3tdy1b?file=src%2FApp.tsx

If body is undefined you can reproduce the issue easily in the browser. client.POST('/', {body:undefined})

[FreeAoi]

Alr makes sense https://github.com/drwpow/openapi-typescript/blob/main/packages/openapi-fetch/src/index.js#L17 return a false positive, you could do the PR fixing this by changing that conditional to !(key in this)