Support JSONSchema $defs #1317
Merged
Support JSONSchema $defs #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4a4b837 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
force-pushed
the
jsonschema-defs
branch
from
e3617c0
to
23f816d
Compare
Deploying with
|
| Latest commit: |
4a4b837
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bc030e61.openapi-ts.pages.dev |
| Branch Preview URL: | https://jsonschema-defs.openapi-ts.pages.dev |
drwpow
force-pushed
the
jsonschema-defs
branch
6 times, most recently
from
ef6afaf
to
8ce204c
Compare
drwpow
commented
Aug 20, 2023
| subschemaOutput += "{\n"; | ||
| indentLv++; | ||
|
|
||
| outer: for (const [name, schemaObject] of getEntries(subschema.schema!)) { |
There was a problem hiding this comment.
Clean up a lot of duplicated transforming of a map of schema objects with transformSchemaObjectMap().
drwpow
commented
Aug 20, 2023
| @@ -15704,7 +16002,7 @@ export interface external { | |||
| vpcs?: external["resources/vpcs/models/vpc.yml"]["vpc"][]; | |||
| } & external["shared/pages.yml"]["pagination"] & external["shared/meta.yml"]; | |||
| }; | |||
| } | |||
| }; | |||
drwpow
commented
Aug 20, 2023
| @@ -14970,8 +15105,92 @@ export interface external { | |||
| default: external["shared/responses/unexpected_error.yml"]; | |||
| }; | |||
| } | |||
| "resources/uptime/models/alert.yml": unknown; | |||
| "resources/uptime/models/check.yml": unknown; | |||
There was a problem hiding this comment.
Also many unknowns were fixed by treating more remote $refs as Schema Object maps
drwpow
force-pushed
the
jsonschema-defs
branch
from
8ce204c
to
663bd5e
Compare
drwpow
force-pushed
the
jsonschema-defs
branch
from
fc82e59
to
4a4b837
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1261 and adds support for JSONSchema
$defsthat can be defined on any object type or the root schema itselfAlthough in JSONSchema,
$defscan be defined anywhere, unfortunately TypeScript doesn’t allow you to define keys on anything other than anobject. For example, if you tried putting$defson astring, how would you access them? Keep in mind that only object types (and the root schema itself) will keep their$defs.How to Review
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)