Fix discriminator propertyName inference #1342
Conversation
🦋 Changeset detectedLatest commit: 8169953 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying with
|
| Latest commit: |
8169953
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f71c24a6.openapi-ts.pages.dev |
| Branch Preview URL: | https://disc.openapi-ts.pages.dev |
drwpow
changed the title
| // core type: properties + additionalProperties | ||
| const coreType: string[] = []; | ||
|
|
||
| // discriminators | ||
| for (const k of ["oneOf", "allOf", "anyOf"] as ("oneOf" | "allOf" | "anyOf")[]) { |
There was a problem hiding this comment.
Note: this was moved up before property generation due to the change in automatic discriminator.propertyName possibly adding keys to the object. We can’t detect if there may be a key conflict, but we can let the explicit properties override it if they come afterward.
| if (Array.isArray(node.oneOf)) { | ||
| for (const child of node.oneOf) { | ||
| if (!child || typeof child !== "object" || !("$ref" in child)) continue; | ||
| oneOf.push(child.$ref); |
There was a problem hiding this comment.
This adds automatic inference from parent oneOf types, but unfortunately the mapping is brittle (probably breaks for remote schemas).
I think the only way to fix this is if this library pre-bundled schemas via something like Redocly bundle
Changes
Fixes an issue where
propertyNamewasn’t automatically generated fordiscriminators(mappings are not required; they only are needed to override the automatic inference).Related to #1158 and #1116
How to Review
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)