Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert top-level parameters object sometimes being optional (#1335, #1352) #1355

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Sep 25, 2023

Changes

Reverts #1335 and #1352, but keeps some related fixes.

How to Review

Tests added; tests should pass.

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

🦋 Changeset detected

Latest commit: bcdf1b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-typescript Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 25, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bcdf1b5
Status: ✅  Deploy successful!
Preview URL: https://882981fe.openapi-ts.pages.dev
Branch Preview URL: https://revert-optional-parameters.openapi-ts.pages.dev

View logs

@drwpow drwpow changed the title Revert top-level parameters object sometimes being optional (#1335) Revert top-level parameters object sometimes being optional (#1335, #1352) Sep 25, 2023
@drwpow drwpow merged commit 7568941 into main Sep 25, 2023
8 checks passed
@drwpow drwpow deleted the revert-optional-parameters branch September 25, 2023 15:24
@github-actions github-actions bot mentioned this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant