Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Include" and "exclude" path documentation is incorrect #54

Closed
kmjennison opened this issue May 11, 2018 · 2 comments
Closed

"Include" and "exclude" path documentation is incorrect #54

kmjennison opened this issue May 11, 2018 · 2 comments

Comments

@kmjennison
Copy link

The documentation for --include and --exclude says "Paths are relative to the root dir of the package to be patched." However, the fileName here appears to be relative to the parent repository. I see a prefix of node_modules/the-package-being-patched/ for every file.

Documentation should read: "Paths are relative to your project's root directory."

@ds300
Copy link
Owner

ds300 commented May 12, 2018

Hi! 👋 You're completely right. Thanks for raising the issue 🙇 I'll fix this asap.

@ds300 ds300 closed this as completed in d776a60 May 12, 2018
@ds300
Copy link
Owner

ds300 commented May 12, 2018

I decided to fix the implementation to be scoped properly, rather than change the docs. Thanks again! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants