Update about Python versions #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfitz
reviewed
Nov 15, 2021
paulfitz
force-pushed
the
python-version
branch
from
8b26cac
to
d66ae51
Compare
|
@dsagal @alexmojaki I added some notes about features helpful for migrating, and common issues we've seen so far. |
alexmojaki
commented
Nov 18, 2021
alexmojaki
commented
Nov 18, 2021
alexmojaki
commented
Nov 18, 2021
|
Overall this looks great, much better than what I was probably going to write. I really didn't know how much detail to go for. |
|
Latest commit assumes the changes in https://phab.getgrist.com/D3147 are in production (so this pull request shouldn't be merged until then) |
alexmojaki
commented
Nov 22, 2021
help/python.md
Outdated
| from urllib.parse import quote_plus | ||
| ``` | ||
|
|
||
| ### There is a subtle change in rounding |
There was a problem hiding this comment.
Suggested change
| ### There is a subtle change in rounding | |
| ### Subtle change in rounding |
alexmojaki
commented
Nov 22, 2021
help/python.md
Outdated
|
|
||
| ### There is a subtle change in rounding | ||
|
|
||
| Python 3 switches from rounding the way many people learned in school |
There was a problem hiding this comment.
Suggested change
| Python 3 switches from rounding the way many people learned in school | |
| Python 3 switches the builtin function `round()` from rounding the way many people learned in school |
|
Apart from those minor suggestions I think this is ready. I can't approve it normally because it's my PR lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.