Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Members can invite members #21

Closed
xman2000 opened this issue Jan 29, 2014 · 6 comments
Closed

Members can invite members #21

xman2000 opened this issue Jan 29, 2014 · 6 comments

Comments

@xman2000
Copy link

Hi,
I just installed and tried the new version of the app and it is working much better - thanks! One thing I did notice is that members can invite members, is this by design? I would think only organizational users should be able to invite members but maybe I am missing something. Thanks again!

Stephen

@dsaronin
Copy link
Contributor

Thanks! The issue you raise is one of roles & authorizations, which is
outside the scope of milia -- a multi-tenanting gem. My only purpose of
including it in the sample app is to show the mechanics of how to do it.
And in my own web app, it new member invitations is restricted to
managerial levels. But these are things done in the views and controllers,
not milia itself. The README discusses roles & authorizations briefly and
gives some recommendations of other gems to support that.

On Tue, Jan 28, 2014 at 5:49 PM, xman2000 notifications@github.com wrote:

Hi,
I just installed and tried the new version of the app and it is working
much better - thanks! One thing I did notice is that members can invite
members, is this by design? I would think only organizational users should
be able to invite members but maybe I am missing something. Thanks again!

Stephen

Reply to this email directly or view it on GitHubhttps://github.com//issues/21
.

@xman2000
Copy link
Author

I was thinking this might be the case but I appreciate the response. One more quick question.... Do you feel the beta is to the point where I can safely integrate it into my app... in other words are you anticipating any significant changes before the final version of 1.0? Thanks,

Stephen

@dsaronin
Copy link
Contributor

Yes, I feel the beta is safe to integrate. I am integrating it now into my
app. I've tested most of the direct stuff; the token authentication stuff
is still to be tested. But the basic changes, which I am anticipating, will
be eventually adding in better unit testing (I plan on totally revamping
the testing), any bug fixes that might come up, and corrections to
documentation.

On Tue, Jan 28, 2014 at 7:36 PM, xman2000 notifications@github.com wrote:

I was thinking this might be the case but I appreciate the response. One
more quick question.... Do you feel the beta is to the point where I can
safely integrate it into my app... in other words are you anticipating any
significant changes before the final version of 1.0? Thanks,

Stephen

Reply to this email directly or view it on GitHubhttps://github.com//issues/21#issuecomment-33553638
.

@xman2000
Copy link
Author

Great, thanks for the explanation(s)! I believe this "issue" can be closed.

@dsaronin
Copy link
Contributor

Hi Stephen,
FYI to let let you know I've had to make a small addition to the
Tenant.create_new_tenant parameters. It's now in v1.0.0-beta-6. The
necessity cropped up while integrating into complex applications. The
README has been changed to reflect the changes, as well as the
sample-milia-app.

On Wed, Jan 29, 2014 at 7:44 AM, xman2000 notifications@github.com wrote:

Closed #21 #21.

Reply to this email directly or view it on GitHubhttps://github.com//issues/21
.

@xman2000
Copy link
Author

I appreciate the update, thank you! I have been going through the sample app and taking a look at your roles gem so I still have plenty of time to make changes before I really commit a lot of code to the app I am working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants