Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all 'Ensure' parameters to default to 'Present' #29

Closed
PlagueHO opened this issue May 19, 2017 · 0 comments · Fixed by #126
Closed

Convert all 'Ensure' parameters to default to 'Present' #29

PlagueHO opened this issue May 19, 2017 · 0 comments · Fixed by #126
Assignees
@PlagueHO
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community.

Comments

@PlagueHO
Copy link
Member

All Ensure parameters are currently required parameters with no default. It would make it easier to use these resources if they were defaulted and no longer required.
@PlagueHO PlagueHO added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels May 19, 2017
@PlagueHO PlagueHO self-assigned this May 19, 2017
@PlagueHO PlagueHO mentioned this issue May 19, 2017
Merged
@SteveL-MSFT SteveL-MSFT added this to Help Wanted in powershell/dscresources May 14, 2019
@SteveL-MSFT SteveL-MSFT removed this from Help Wanted in powershell/dscresources Nov 27, 2019
Borgquite added a commit to Borgquite/DFSDsc that referenced this issue Oct 20, 2022
@Borgquite
Convert all 'Ensure' parameters to default to 'Present' dsccommunity#29
f4b4a74
@Borgquite Borgquite mentioned this issue Oct 20, 2022
Merged
9 tasks
PlagueHO pushed a commit that referenced this issue Aug 3, 2023
@Borgquite
BREAKING CHANGE:
89db2ba 
 - Add support for setting a DFS Namespace root target's referral status (state) to be either Online or Offline
   in MSFT_DFSNamespaceRoot. State is now a required parameter.
 - Add support for setting a DFS Namespace folder target's referral status (state) to be either Online or Offline
   in MSFT_DFSNamespaceFolder. State is now a required parameter.
 - Update examples to support new required parameter.

* Fixes the description of the Example 1 for DFSNamespaceFolder and DFSNamespaceRoot.

* Fixes a typo in Example 1 for DFSNamespaceFolder and DFSNamespaceRoot examples.

* Add DFSReplicationGroupMember to define members separate from a group

* Add DFSReplicationGroupMember tests

* Allow Get-TargetResource & Test-TargetResource when replication group does not exist (fix #125)

* Add support for CrossFileRDCEnabled, MinimumRDCFileSizeInKB in DSC_DFSReplicationGroupConnection plus EnsureEnabled, MinimumFileStagingSize, ConflictAndDeletedQuotaInMB, RemoveDeletedFiles and DfsnPath in DFSReplicationGroupMembership

* Add tests for new parameters in DFSReplicationGroupConnections

* Add tests for new parameters in DFSReplicationGroupMembership

* Add new strings for DFSReplicationGroupMembership

* Convert all 'Ensure' parameters to default to 'Present' #29

* Spelling corrections

* Correction to (copied?) comment referencing incorrect file

* Merge branch 'bsmall_referral_status_support'

* Merge branch 'wayfair-contribs-bsmall_referral_status_support' into patch-1

* Fix ReplicationGroup integration tests testing for Namespace feature

* Rename 'State' to 'TargetState' to avoid clash with existing 'State' property, make it optional (to avoid breaking change)

* Finalise above change

* Update examples to use TargetState instead of State

* Revert error

* TargetState integration tests for DFSNamespaceRoot

* Fix whitespace

* TargetState unit tests for DFSNamespaceFolder and DFSNamespaceRoot

* Fix DFSReplicationGroupConnection EnsureRDCEnabled test

* Fix tests to increment instead of using fixed values

* Updated CHANGELOG

* Fix error in CHANGELOG

* Another CHANGELOG fix

* Add 'State' back into DFSNamespaceRoot Schema

* Fix Set-TargetResource check for TargetState

* Update DFSReplicationGroup tests as now the Members attribute can be blank for use with DFSReplicationGroupMember

* Update DFSReplicationGroup tests as now the Members attribute can be blank (2)

* Revert ability to leave Folders blank too (breaks tests)

* Fix DFSReplicationGroup test, (spelling mistake)

* DFSReplicationGroupFolder and DFSReplicationGroupMembership should not fail on do not exist (update test for #125)

* Fix bugs in DFSReplicationGroupMember tests

* Update CHANGELOG

* Separate change log entries into sections for each resource

* New ReplicationGroup sample, fixes to TargetState descriptions

* Pin build image to Ubuntu 20.04 - fixes #127

* Changelog tweaks

* DFSReplicationGroup fixes - additional Member warnings, fix for empty $Members array

* DFSReplicationGroupMember warning

* Fixed example

* Replace 2016-Datacenter,2016-Datacenter-Server-Core with 2019-Datacenter,2019-Datacenter-Server-Core (all examples)

* DFSReplicationGroup example Members warning

* More DFSReplicationGroup / DFSReplicationGroupMember example fixes

* Replace -Be [$true/$false/$null] with -BeTrue -BeFalse -BeNullOrEmpty

* Remove unnecessary 'Offline' from examples

* Revert $Members change - fix texts

* Grammatical error

* Support clearing out members from a replication group

* Attempt to fix DFSReplicationGroup tests - 'no members'

* Same fix for no Members for ContentPaths

* Same fix as Null Members for Null Folders in tests

Co-Authored-By: Ben Small <bsmall@wayfair.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PlagueHO PlagueHO

Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Milestone
No milestone
1 participant
@PlagueHO