Converted to use Wiki Auto Documentation, Appveyor Shared Code and HQRM - Fixes #25 #26

PlagueHO · 2017-02-21T07:48:48Z

This PR contains the following changes:

Converted AppVeyor build process to use AppVeyor.psm1.
Resolved PSSA violations.
Resolved Readme.md style violations.
Converted Integration Tests to use Test Drive and stop using Invoke-Pester.
Move strings into separate language files.
Added CodeCov support.
Clean up manifest file by removing commented out sections.
Convert Examples to pass tests and meet minimum standards.
Convert to Wiki and auto-documentation generation.
Convert to TestHarness test execution method.

This change is

* Resolved PSSA violations. * Resolved Readme.md style violations. * Converted Integration Tests to use Test Drive and stop using Invoke-Pester.

* Added CodeCov support.

codecov-io · 2017-02-21T07:53:36Z

Codecov Report

❗ No coverage uploaded for pull request base (dev@c3025f0). Click here to learn what that means.
The diff coverage is 99%.

@@         Coverage Diff          @@
##             dev    #26   +/-   ##
====================================
  Coverage       ?    96%           
====================================
  Files          ?      7           
  Lines          ?   1017           
  Branches       ?      0           
====================================
  Hits           ?    985           
  Misses         ?     32           
  Partials       ?      0

PlagueHO · 2017-04-27T08:04:52Z

@johlju - do you think I could get you to code review this for me if you ever have a moment (week)? I know this is a large change, but it's mainly around style rather than logic.

johlju · 2017-04-27T14:48:46Z

Absolutely, I can help you with this, but i'm afraid it won't be until next week. A lot of stuff in xSQLServer that has stacked up this week :)

PlagueHO · 2017-04-28T06:30:50Z

Thank you so much @johlju - and absolutely no rush - I've had this sitting around for a couple on months so it can wait longer 😁

PlagueHO · 2017-05-19T08:38:59Z

Review status: 53 of 79 files reviewed at latest revision, 297 unresolved discussions.

.markdownlint.json, line 3 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

New line at the end here.

Done.

README.md, line 12 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Is is possible to get a link on these resource names to their respectively wiki page?

Done. Although the links will only work once this release has gone to master so that the Wiki can be published.

README.md, line 13 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Installation
Install-Module -Name xDFS -MinimumVersion 3.0.0.0
You removed this. Because it was moved to the wiki?

No, I removed it because it wasn't part of the standard DSC Resource information header - none of the other resources (xNetworking, xStorage, xCertificate etc) included it and it just added maintenance overhead (had to remember to update it on every release).

README.md, line 31 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Add a reference (link) to the 'Domain Credentials' section down below? Or move up the 'Domain Credentials' section here?

I thought it would be cleaner to move the section up - so have done so.

Modules/xDFS/xDFS.psd1, line 40 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Remove blank line here?

Done.

Modules/xDFS/xDFS.psd1, line 58 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Remove blank line here?

Done.

Modules/xDFS/xDFS.psd1, line 60 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Remove blank line here?

Done.

Modules/xDFS/xDFS.psd1, line 62 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Remove blank line here?

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 38 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Does Ensure need to be mandatory (Required)? Isn't it enough for it to be Write with a default value of 'Present'?
If it was Write then this parameter would not be needed here in the Get-method since it doesn't seem to be used.
If it needs to be required, then add to the parameter description in comment based help that it is not used in Get-TargetResource.

I do agree - we could convert this (and all other) "Ensure" parameters over to a default value, but I was trying to avoid making any functional changes in this PR. I was restricting myself to only doing style changes to bring it up to guidelines. Happy to change it now, but might be better for another PR. Same goes for the other "Ensure" parameters.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 58 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Why this row? Can't see it is being used anywhere.

Copy/Paste 😁. Removed.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 267 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Minor: Looping through these seem excessive unless $VerbosePreference -ne 'SilentlyContinue' since the foreach does nothing unless Verbose messages should be outputted? But I'm good keeping it as is too.

Cool. I might leave it as is, only because the DFS implementation on Windows can be a complicated and tricky thing I like to provide as much info for diagnostics as possible (even now I have trouble getting DFS correct 😁 )

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 331 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Minor: Same comment as above

Same as above 😁

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 341 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment block

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 356 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Minor: Same comment as above

As above 😁

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 529 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Change to $targetFolder

Done. Plus changed all other instances of $target to $targetFolder to match.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 533 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Change to $targetFolder

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 536 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Change to $targetFolder

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 546 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Change to $targetFolder

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 582 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Change to $targetFolder

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 586 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Change to $targetFolder

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 649 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

lower 't'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 690 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

lower 't'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.schema.mof, line 4 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Key - Upper 'K'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.schema.mof, line 5 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Key - Upper 'K'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 3 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This only have one placeholder, but there is two objects sent in.

Wow - amazing catch. I removed the other parameter - it shouldn't be there.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 4 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This only have one placeholder, but there is two objects sent in.

Wow - amazing catch. I removed the other parameter - it shouldn't be there.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 5 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Shouldn't these and most other strings say '..on target...' adding 'on'?

Fair call. Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 8 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This only have three placeholders, but there is four objects sent in.

Fixed.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 10 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

NamespaceFolderCreatedMessage

This is not used

Great catch. Fixed.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 13 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This only have two placeholders, but there is three objects sent in.

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 15 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This only have one placeholder, but there is two objects sent in.

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 18 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This only have one placeholder, but there is two objects sent in.

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 41 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Does Ensure need to be mandatory (Required)? Isn't it enough for it to be Write with a default value of 'Present'?
If it was Write then this parameter would not be needed here in the Get-method since it doesn't seem to be used.
If it needs to be required, then add to the parameter description in comment based help that it is not used in Get-TargetResource.

See previous comments about functional changes. I do think this should be done though - just in a separate PR.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 67 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This is not used anywhere?

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 335 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Minor: Same comment as a comment in another resource

See comment from previous resource.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 399 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Minor: Same comment as a comment in another resource

See comment from previous resource.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 409 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment block

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 424 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Minor: Same comment as a comment in another resource

See comment from previous resource.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 585 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment block

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 791 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

lower 't'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 832 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

lower 't'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.schema.mof, line 4 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'K' in Key

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.schema.mof, line 5 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'K' in Key

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 2 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Should not these and the rest be '...on target...'? If so, then do that for all the strings throughout the module

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 3 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Only one placeholder, but two objects sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 10 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

NamespaceRootCreatedMessage

This is not used

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 13 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Only two placeholders, but four objects sent in

Fixed and fixed.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 14 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Only three placeholders, but four objects sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 16 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Only two placeholders, but three objects sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 19 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Only two placeholders, but three objects sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 14 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

lower 'w' in 'Will'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 19 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Hashtable should be formatted correctly.

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 20 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Hashtable should be formatted correctly.

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 21 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Hashtable should be formatted correctly.

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 49 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

change to 'localhost'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 51 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

change to 'localhost'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 120 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

change to 'localhost'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 122 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

change to 'localhost'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 234 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

change to 'localhost'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceServerConfiguration/MSFT_xDFSNamespaceServerConfiguration.psm1, line 236 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

change to 'localhost'

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 33 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Does Ensure need to be mandatory (Required)? Isn't it enough for it to be Write with a default value of 'Present'?
If it was Write then this parameter would not be needed here in the Get-method since it doesn't seem to be used.
If it needs to be required, then add to the parameter description in comment based help that it is not used in Get-TargetResource.

See previous comments about Functional changes (though def agree it should be done).

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 74 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment block

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 80 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Should this row be commented? If so, then it could be removed

I've moved these commented parameters into the previous comment as I'm waiting for the above user voice issue to be resolved so I can allow them to be added back in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 81 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Should this row be commented? If so, then it could be removed

See above.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 82 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Should this row be commented? If so, then it could be removed

I've uncommented these.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 222 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 226 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 241 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 242 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 279 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 297 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 317 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 335 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 349 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 361 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 362 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 369 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 375 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 407 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 414 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 425 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 444 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 451 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 610 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 626 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 645 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Change to $primaryMember

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 649 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Change to $primaryMember

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 660 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 700 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 710 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 739 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/MSFT_xDFSReplicationGroup.psm1, line 751 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Could you add blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 2 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 3 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 4 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 5 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 6 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 8 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 9 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 10 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only two placeholders, but three objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 11 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only two placeholders, but three objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 12 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only two placeholders, but three objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 13 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only two placeholders, but three objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 14 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only two placeholders, but three objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 15 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 16 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only three placeholders, but four objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 17 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only three placeholders, but four objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 18 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 19 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 20 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 21 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 22 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only two placeholders, but three objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 23 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 24 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 25 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only one placeholder, but two objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 26 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only three placeholders, but four objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 27 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only three placeholders, but four objects are sent in

Fixed by removing parameter from being passed in.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/MSFT_xDFSReplicationGroupMembership.psm1, line 48 at r3 (raw file):

[System.String]

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/MSFT_xDFSReplicationGroupMembership.psm1, line 49 at r3 (raw file):

System.Strin

Comments from Reviewable

PlagueHO · 2017-05-19T09:03:40Z

Review status: 48 of 79 files reviewed at latest revision, 297 unresolved discussions.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/MSFT_xDFSReplicationGroupConnection.psm1, line 53 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Does Ensure need to be mandatory (Required)? Isn't it enough for it to be Write with a default value of 'Present'?
If it was Write then this parameter would not be needed here in the Get-method since it doesn't seem to be used.
If it needs to be required, then add to the parameter description in comment based help that it is not used in Get-TargetResource.

See previous resource comments about functional changes (next time 😁)

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/MSFT_xDFSReplicationGroupConnection.psm1, line 65 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This localization string does not exist

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/MSFT_xDFSReplicationGroupConnection.psm1, line 302 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this row

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/MSFT_xDFSReplicationGroupConnection.psm1, line 391 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This localization string does not exist

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/MSFT_xDFSReplicationGroupConnection.psm1, line 494 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 2 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

GettingReplicationGroupMessage

This is not used

Name was incorrect. Fixed.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 3 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This used three placeholders, but four objects are sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 4 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This used three placeholders, but four objects are sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 5 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This used three placeholders, but for objects are sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 6 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This used three placeholders, but four objects are sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 7 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This used three placeholders, but four objects are sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 8 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This used three placeholders, but four objects are sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 9 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This used three placeholders, but four objects are sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 10 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This used three placeholders, but four objects are sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 11 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

TestingConnectionRegGroupMessage

This is not used

Name was incorrect. Fixed.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 12 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This used four placeholders, but five objects are sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 13 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This used three placeholders, but four objects are sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 14 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This used three placeholders, but four objects are sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupConnection/en-us/MSFT_xDFSReplicationGroupConnection.strings.psd1, line 15 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This used three placeholders, but four objects are sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/MSFT_xDFSReplicationGroupFolder.psm1, line 78 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Should this be commented? If so please remove the row

Moved up to previous comment block because they should be added back in when the uservoice item is fixed.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/MSFT_xDFSReplicationGroupFolder.psm1, line 79 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Should this be commented? If so please remove the row

Moved up to previous comment block because they should be added back in when the uservoice item is fixed.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/MSFT_xDFSReplicationGroupFolder.psm1, line 276 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

blank row before this one

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/README.md, line 4 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

'...folder Description, FilenameToExclude or DirectoryNameToExclude fields need...'

Could we revise this text?
Maybe '...folder properties Description, FilenameToExclude or DirectoryNameToExclude need...'

Done. I changed it to a list.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 2 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses two placeholders, but three objects are sent in

Done. Removed extra parameter.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 3 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses two placeholders, but three objects are sent in

Done. Removed extra parameter.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 4 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses two placeholders, but three objects are sent in

Done. Removed extra parameter.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 5 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses two placeholders, but three objects are sent in

Done. Removed extra parameter.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 6 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses two placeholders, but three objects are sent in

Done. Removed extra parameter.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 7 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses two placeholders, but three objects are sent in

Done. Removed extra parameter.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 8 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses two placeholders, but three objects are sent in

Done. Removed extra parameter.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 9 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses two placeholders, but three objects are sent in

Done. Removed extra parameter.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 10 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses two placeholders, but three objects are sent in

Done. Removed extra parameter.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupFolder/en-us/MSFT_xDFSReplicationGroupFolder.strings.psd1, line 11 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses two placeholders, but three objects are sent in

Done. Removed extra parameter.

Comments from Reviewable

PlagueHO · 2017-05-19T09:51:41Z

Okay! Thanks again @johlju - I really appreciate your thoroughness! I think I've resolved everything now 😁

Review status: 27 of 79 files reviewed at latest revision, 297 unresolved discussions, some commit checks broke.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 2 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Fixed by removing parameter from being passed in.

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroup/en-us/MSFT_xDFSReplicationGroup.strings.psd1, line 7 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This has only one placeholder, but two objects are sent in

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/MSFT_xDFSReplicationGroupMembership.psm1, line 89 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

blank row before this one

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/MSFT_xDFSReplicationGroupMembership.psm1, line 90 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

blank row before this one

Done.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 2 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses three placeholders, but four objects are sent in

Fixed by removing extra parameter from resource (shouldn't have been passed.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 3 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses three placeholders, but four objects are sent in

Fixed by removing extra parameter from resource (shouldn't have been passed.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 4 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses three placeholders, but four objects are sent in

Fixed by removing extra parameter from resource (shouldn't have been passed.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 5 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses three placeholders, but four objects are sent in

Fixed by removing extra parameter from resource (shouldn't have been passed.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 6 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses three placeholders, but four objects are sent in

Fixed by removing extra parameter from resource (shouldn't have been passed.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 7 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses three placeholders, but four objects are sent in

Fixed by removing extra parameter from resource (shouldn't have been passed.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 8 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses three placeholders, but four objects are sent in

Fixed by removing extra parameter from resource (shouldn't have been passed.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 9 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses three placeholders, but four objects are sent in

Fixed by removing extra parameter from resource (shouldn't have been passed.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 10 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This uses three placeholders, but four objects are sent in

Fixed by removing extra parameter from resource (shouldn't have been passed.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/en-us/MSFT_xDFSReplicationGroupMembership.strings.psd1, line 11 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

ReplicationGroupMembershipPrimaryMemberismatchMessage

Typo in name, should be 'ReplicationGroupMembershipPrimaryMemberMismatchMessage'

This also only uses three placeholders, but four objects are sent in

Wow! Amazing catch there! Fixed!

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 16 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'PSC'

Fixed (and in all other examples)

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 28 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 43 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 53 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 62 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This should be 'ny-fileserver'

Great catch! Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 63 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 74 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 83 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 91 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This should be 'ny-fileserver'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/1_Domain_MultipleTarget.ps1, line 92 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/2_Domain_SingleTarget.ps1, line 4 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Maybe more detail '...sub-folders are defined under the departments folder...'?

My spellchecker in Chrome does not like 'subfolders' it wants it to be 'sub-folders' or sub folders'. You know best here :)

Done... and Chrome knows best 😁

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/2_Domain_SingleTarget.ps1, line 16 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'PSC'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/2_Domain_SingleTarget.ps1, line 28 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/2_Domain_SingleTarget.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/2_Domain_SingleTarget.ps1, line 43 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/2_Domain_SingleTarget.ps1, line 55 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/2_Domain_SingleTarget.ps1, line 65 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/3_Standalone_FQDN.ps1, line 4 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Here it's named namespace and not sub-folders (seen in another example). Which is correct?

Actually, it should have been sub-folders - you're quite correct 😁 - Fixed.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/3_Standalone_FQDN.ps1, line 4 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Brochures

Upper 'B' here, while it's lower B in the actual path below and in the resource configuration.

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/3_Standalone_FQDN.ps1, line 16 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'PSC'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/3_Standalone_FQDN.ps1, line 24 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment block

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/3_Standalone_FQDN.ps1, line 28 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/3_Standalone_FQDN.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/3_Standalone_FQDN.ps1, line 51 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/3_Standalone_FQDN.ps1, line 62 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 4 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Brochures

Same comment as another example... Namespace and not sub-folder, and upper 'B', but not in the path.

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 16 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'PSC'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 24 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment block here

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 28 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single qoutes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single qoutes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 38 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment out of alignment

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 43 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P' in present

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 49 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment out of alignment

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceFolder/4_Standalone.ps1, line 54 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P' in present

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 16 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'PSC'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 24 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment block

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 28 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 38 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment out of alignment

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 43 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 53 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 62 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Should be 'ny-fileserver'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 63 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 74 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 83 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 91 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Should be 'ny-fileserver'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 92 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 16 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

[PSCredential] Upper 'PSC'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 24 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment block here

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 28 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 38 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment out of alignement

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 43 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P' in present

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 50 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment out of alignement

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 55 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P' in present

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 65 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P' in present

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 4 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Same comment about 'Brochures' and namespace as other example file comments

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 16 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'PSC'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 24 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment block

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 28 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 38 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment out of alignment

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 46 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment out of alignment

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 51 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 62 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/4_Standalone.ps1, line 4 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Same comment about 'Brochures' and namespace as other example file comments

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/4_Standalone.ps1, line 16 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'PSC'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/4_Standalone.ps1, line 28 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/4_Standalone.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/4_Standalone.ps1, line 38 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment out of alignment

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/4_Standalone.ps1, line 43 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/4_Standalone.ps1, line 49 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment out of alignment

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/4_Standalone.ps1, line 54 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 16 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'PSC'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 24 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment block

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 28 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 38 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment is out of alignment

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 46 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment is out of alignment

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 51 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 57 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment is out of alignment

Done.

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 62 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'P'

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/1_FullMesh.ps1, line 17 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'PSC'

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/1_FullMesh.ps1, line 25 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment block

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/1_FullMesh.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/1_FullMesh.ps1, line 30 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/1_FullMesh.ps1, line 43 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/2_Simple.ps1, line 17 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'PSC'

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/2_Simple.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/2_Simple.ps1, line 30 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/2_Simple.ps1, line 44 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/3_Complete.ps1, line 6 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Where does it set to manual topology? Was expecting a parameter for that set to 'Manual' (out of my depth here so not sure how it works) :)

Good catch. The default value for Topology is "Manual" if it is not specified, so I've clarified what this means.

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/3_Complete.ps1, line 17 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'DSC'

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/3_Complete.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/3_Complete.ps1, line 30 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/3_Complete.ps1, line 42 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroup/3_Complete.ps1, line 59 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Meant for this to be FQDN but not FileServer1 in previous resource?

I changed them all to be FQDN to make it clear (FQDN Is always better anyway).

Modules/xDFS/Examples/Resources/xDFSReplicationGroupConnection/1_Complete.ps1, line 6 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Same question about 'manual topology' as another example file comment :)

Fixed as per previous.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupConnection/1_Complete.ps1, line 17 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'PSC'

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupConnection/1_Complete.ps1, line 25 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment block

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupConnection/1_Complete.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupConnection/1_Complete.ps1, line 30 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupConnection/1_Complete.ps1, line 42 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupConnection/1_Complete.ps1, line 59 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Meant for this to be FQDN but not FileServer1 in previous resource?

Fixed as per previous.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/1_FullMesh.ps1, line 17 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'PSC'

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/1_FullMesh.ps1, line 25 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment block

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/1_FullMesh.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/1_FullMesh.ps1, line 30 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/1_FullMesh.ps1, line 43 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/2_Complete.ps1, line 6 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Same comment about manual here as other example

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/2_Complete.ps1, line 17 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'PSC'

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/2_Complete.ps1, line 25 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment block

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/2_Complete.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/2_Complete.ps1, line 30 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/2_Complete.ps1, line 42 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupFolder/2_Complete.ps1, line 59 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

FQDN here, but fileserver1 above is not FQDN. Is it meant to be this way?

Fixed same as previous time - it'll work either way, but changed to FQDN for consistency.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/1_FullMesh.ps1, line 17 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'PSC'

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/1_FullMesh.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/1_FullMesh.ps1, line 30 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/1_FullMesh.ps1, line 43 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/2_Complete.ps1, line 6 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Same question about manual as other example

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/2_Complete.ps1, line 17 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Upper 'PSC'

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/2_Complete.ps1, line 29 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/2_Complete.ps1, line 30 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/2_Complete.ps1, line 42 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Examples/Resources/xDFSReplicationGroupMembership/2_Complete.ps1, line 59 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Meant to be FQDN here and not fileserver1 in the previous resource?

Done.

Modules/xDFS/Modules/DFSDsc.ResourceHelper/DFSDsc.ResourceHelper.psm1, line 11 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Modules/DFSDsc.ResourceHelper/DFSDsc.ResourceHelper.psm1, line 12 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Single quotes

Done.

Modules/xDFS/Modules/DFSDsc.ResourceHelper/DFSDsc.ResourceHelper.psm1, line 21 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Missing Parameter description in comment-based help

Done.

Tests/TestHelpers/CommonTestHelper.psm1, line 33 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Minor: Blank row before this one

Done.

Tests/TestHelpers/CommonTestHelper.psm1, line 81 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Minor: Blank row before this one

Done.

Comments from Reviewable

johlju · 2017-05-19T16:46:44Z

Oh man... That was a lot of acknowledgment. It took me like half an hour. It must have taken you ages to fix and comment on all of those haha 😉

Just a few misses. And I will review the tests tomorrow. I will start with a test today, but have to stop when dinner is ready. 😄

Reviewed 11 of 94 files at r1, 38 of 41 files at r4.
Review status: 65 of 79 files reviewed at latest revision, 14 unresolved discussions, some commit checks broke.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 38 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

I do agree - we could convert this (and all other) "Ensure" parameters over to a default value, but I was trying to avoid making any functional changes in this PR. I was restricting myself to only doing style changes to bring it up to guidelines. Happy to change it now, but might be better for another PR. Same goes for the other "Ensure" parameters.

Let's change it later in another PR. But you could make a issue for that so it doesn't get forgotten. :)

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 15 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Done.

Doesn't seem to be fixed :)

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 18 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Done.

This is not fixed either. :)

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 585 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Done.

Missed this one :)

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 19 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Done.

You missed this one too :)

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/MSFT_xDFSReplicationGroupMembership.psm1, line 48 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

[System.String]

OK. You got rouge comment here :) Hope you can Ack this now.

Modules/xDFS/DSCResources/MSFT_xDFSReplicationGroupMembership/MSFT_xDFSReplicationGroupMembership.psm1, line 49 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

System.Strin

OK. You got rouge comment here :) Hope you can Ack this now.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 24 at r4 (raw file):

    Node $NodeName
    {
        # Install the Prerequisite features first

Comment block here (was to quick to resolve the first comment)

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 24 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Done.

No comment block yet :)

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 38 at r4 (raw file):

        }

       # Configure the namespace

Comment still out of alignment

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 50 at r4 (raw file):

        } # End of DFSNamespaceRoot Resource

       # Configure the namespace folders

Comment still out of alignment. Eyes playing tricks on me, resolved this one to quickly too. 😆

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 38 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Done.

Still out of alignment :)

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 46 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Done.

Still out of alignment :)

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 38 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Done.

Still out of alignment :)

Comments from Reviewable

johlju · 2017-05-19T17:12:02Z

Time for dinner. 6 unit tests left to review. 😄

Reviewed 6 of 45 files at r2, 2 of 41 files at r4.
Review status: 73 of 79 files reviewed at latest revision, 97 unresolved discussions, some commit checks broke.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 26 at r4 (raw file):

$ProductType

$productType

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 30 at r4 (raw file):

        Context 'Operating System' {
            It 'Should be a Server OS' {
                $ProductType | Should Be 3

same as above

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 34 at r4 (raw file):

        }
    }
    if ($ProductType -ne 3)

same as above

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 34 at r4 (raw file):

        }
    }
    if ($ProductType -ne 3)

Blank row before this one

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 36 at r4 (raw file):

    if ($ProductType -ne 3)
    {
        Break

lower 'b'

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 39 at r4 (raw file):

$Installed

$featureInstalled or $featureFsDfsNamespaceInstalled

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 43 at r4 (raw file):

        Context 'Windows Features' {
            It 'Should have the DFS Namespace Feature Installed' {
                $Installed | Should Be $true

same as above

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 47 at r4 (raw file):

        }
    }
    if ($Installed -eq $false)

same as above

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 49 at r4 (raw file):

    if ($Installed -eq $false)
    {
        Break

lower 'b'

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 60 at r4 (raw file):

        [System.String] $RandomFileName = [System.IO.Path]::GetRandomFileName()
        [System.String] $ShareFolderRoot = Join-Path -Path $env:Temp -ChildPath "$($script:DSCResourceName)_$RandomFileName"
        New-Item `

Blank row before this one. It just a personal preference for it to be easier to read and review the code.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 63 at r4 (raw file):

            -Path $ShareFolderRoot `
            -Type Directory
        New-SMBShare `

Blank row before this one.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 67 at r4 (raw file):

            -Path $ShareFolderRoot `
            -FullAccess 'Everyone'
        [System.String] $RandomFileName = [System.IO.Path]::GetRandomFileName()

Blank row before this one.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 69 at r4 (raw file):

        [System.String] $RandomFileName = [System.IO.Path]::GetRandomFileName()
        [System.String] $ShareFolderFolder = Join-Path -Path $env:Temp -ChildPath "$($script:DSCResourceName)_$RandomFileName"
        New-Item `

Blank row before this one.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 72 at r4 (raw file):

            -Path $ShareFolderFolder `
            -Type Directory
        New-SMBShare `

Blank row before this one.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 76 at r4 (raw file):

            -Path $ShareFolderFolder `
            -FullAccess 'Everyone'
        New-DFSNRoot `

Blank row before this one.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 116 at r4 (raw file):

            -Force `
            -Confirm:$false
        Remove-DFSNRoot `

Blank row before this one.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 120 at r4 (raw file):

            -Force `
            -Confirm:$false
        Remove-SMBShare `

Blank row before this one.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 123 at r4 (raw file):

            -Name $NamespaceFolderName `
            -Confirm:$false
        Remove-Item `

Blank row before this one.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 127 at r4 (raw file):

            -Recurse `
            -Force
        Remove-SMBShare `

Blank row before this one.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 130 at r4 (raw file):

            -Name $NamespaceRootName `
            -Confirm:$false
        Remove-Item `

Blank row before this one.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 26 at r4 (raw file):

$ProductType

$productType

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 30 at r4 (raw file):

        Context 'Operating System' {
            It 'Should be a Server OS' {
                $ProductType | Should Be 3

same as above

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 34 at r4 (raw file):

        }
    }
    if ($ProductType -ne 3)

same as above

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 34 at r4 (raw file):

        }
    }
    if ($ProductType -ne 3)

Blank row before this one.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 36 at r4 (raw file):

    if ($ProductType -ne 3)
    {
        Break

lower 'b'

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 39 at r4 (raw file):

$Installed

$featureInstalled or $featureFsDfsNamespaceInstalled

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 43 at r4 (raw file):

        Context 'Windows Features' {
            It 'Should have the DFS Namespace Feature Installed' {
                $Installed | Should Be $true

same as above

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 47 at r4 (raw file):

        }
    }
    if ($Installed -eq $false)

same as above

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 47 at r4 (raw file):

        }
    }
    if ($Installed -eq $false)

blank row here

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 49 at r4 (raw file):

    if ($Installed -eq $false)
    {
        Break

lower 'b'

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 60 at r4 (raw file):

        [System.String] $RandomFileName = [System.IO.Path]::GetRandomFileName()
        [System.String] $ShareFolderRoot = Join-Path -Path $env:Temp -ChildPath "$($script:DSCResourceName)_$RandomFileName"
        New-Item `

Blank row before this one.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 63 at r4 (raw file):

            -Path $ShareFolderRoot `
            -Type Directory
        New-SMBShare `

Blank row before this one.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 91 at r4 (raw file):

            $NamespaceRootNew.NamespacePath                 | Should Be $NamespaceRoot.Path
            $NamespaceRootNew.Flags                         | Should Be @('Target Failback','Site Costing','Insite Referrals','AccessBased Enumeration')
            $NamespaceRootTargetNew = Get-DfsnRootTarget -Path $NamespaceRoot.Path -TargetPath $NamespaceRoot.TargetPath

Blank row before this one. Or shouldn't this be a separate IT-block?

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 104 at r4 (raw file):

            -Force `
            -Confirm:$false
        Remove-SMBShare `

Blank row before this one.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 107 at r4 (raw file):

            -Name $NamespaceRootName `
            -Confirm:$false
        Remove-Item `

Blank row before this one.

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 26 at r4 (raw file):

{
    # Ensure that the tests can be performed on this computer
    $ProductType = (Get-CimInstance Win32_OperatingSystem).ProductType

Same as previous tests

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 30 at r4 (raw file):

        Context 'Operating System' {
            It 'Should be a Server OS' {
                $ProductType | Should Be 3

Same as previous tests

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 34 at r4 (raw file):

        }
    }
    if ($ProductType -ne 3)

Same as previous tests

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 36 at r4 (raw file):

    if ($ProductType -ne 3)
    {
        Break

lower 'b'

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 39 at r4 (raw file):

    }

    $Installed = (Get-WindowsFeature -Name FS-DFS-Namespace).Installed

Same as previous tests

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 43 at r4 (raw file):

        Context 'Windows Features' {
            It 'Should have the DFS Namespace Feature Installed' {
                $Installed | Should Be $true

Same as previous tests

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 47 at r4 (raw file):

        }
    }
    if ($Installed -eq $false)

Same as previous tests

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 47 at r4 (raw file):

        }
    }
    if ($Installed -eq $false)

Blank row before this one

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 49 at r4 (raw file):

    if ($Installed -eq $false)
    {
        Break

lower 'b'

Tests/Integration/MSFT_xDFSReplicationGroup.Integration.Tests.ps1, line 78 at r4 (raw file):

                    )
                }
                & "$($script:DSCResourceName)_Config" -OutputPath $TestDrive -ConfigurationData $ConfigData

Blank row before this one

Tests/Integration/MSFT_xDFSReplicationGroup.Integration.Tests.ps1, line 94 at r4 (raw file):

            $ReplicationGroupNew.GroupName                 | Should Be $ReplicationGroup.GroupName
            $ReplicationGroupNew.Description               | Should Be $ReplicationGroup.Description
            # Check the members are in the Replication Group

Blank row before this one

Tests/Integration/MSFT_xDFSReplicationGroup.Integration.Tests.ps1, line 102 at r4 (raw file):

                    -ErrorAction Stop
                $ReplicationGroupMemberNew.GroupName       | Should Be $ReplicationGroup.GroupName
                # If Member name was an FQDN then match the DNSName property, otherwise the ComputerName property

Blank row before this one

Tests/Integration/MSFT_xDFSReplicationGroup.Integration.Tests.ps1, line 112 at r4 (raw file):

                }
            }
            # Check the folders are in the Replication Group

Blank row before this one

Tests/Integration/MSFT_xDFSReplicationGroupConnection.Integration.Tests.ps1, line 70 at r4 (raw file):

        New-DFSReplicationGroup `
            -GroupName $ReplicationGroupConnection.GroupName
        foreach ($Member in $ReplicationGroupConnection.Members)

Blank row before this one

Tests/Integration/MSFT_xDFSReplicationGroupConnection.Integration.Tests.ps1, line 76 at r4 (raw file):

                -ComputerName $Member
        }
        foreach ($Folder in $ReplicationGroupConnection.Folders)

Blank row before this one

Tests/Integration/MSFT_xDFSReplicationGroupConnection.Integration.Tests.ps1, line 94 at r4 (raw file):

                    )
                }
                & "$($script:DSCResourceName)_Config" -OutputPath $TestDrive -ConfigurationData $ConfigData

Blank row before this one

Tests/Integration/MSFT_xDFSReplicationGroupFolder.Integration.Tests.ps1, line 70 at r4 (raw file):

        New-DFSReplicationGroup `
            -GroupName $ReplicationGroupFolder.GroupName
        foreach ($Member in $ReplicationGroupFolder.Members)

Blank row before this one

Tests/Integration/MSFT_xDFSReplicationGroupFolder.Integration.Tests.ps1, line 76 at r4 (raw file):

                -ComputerName $Member
        }
        foreach ($Folder in $ReplicationGroupFolder.Folders)

Blank row before this one

Tests/Integration/MSFT_xDFSReplicationGroupFolder.Integration.Tests.ps1, line 94 at r4 (raw file):

                    )
                }
                & "$($script:DSCResourceName)_Config" -OutputPath $TestDrive -ConfigurationData $ConfigData

Blank row before this one

Tests/Integration/MSFT_xDFSReplicationGroupMembership.Integration.Tests.ps1, line 70 at r4 (raw file):

        New-DFSReplicationGroup `
            -GroupName $ReplicationGroupMembership.GroupName
        foreach ($Member in $ReplicationGroupMembership.Members)

Blank row before this one

Tests/Integration/MSFT_xDFSReplicationGroupMembership.Integration.Tests.ps1, line 76 at r4 (raw file):

                -ComputerName $Member
        }
        foreach ($Folder in $ReplicationGroupMembership.Folders)

Blank row before this one

Tests/Integration/MSFT_xDFSReplicationGroupMembership.Integration.Tests.ps1, line 94 at r4 (raw file):

                    )
                }
                & "$($script:DSCResourceName)_Config" -OutputPath $TestDrive -ConfigurationData $ConfigData

Blank row before this one

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 24 at r4 (raw file):

$ProductType

Same as previous test

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 28 at r4 (raw file):

        Context 'Operating System' {
            It 'Should be a Server OS' {
                $ProductType | Should Be 3

Same as previous test

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 32 at r4 (raw file):

        }
    }
    if ($ProductType -ne 3)

Blank row before this one

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 32 at r4 (raw file):

        }
    }
    if ($ProductType -ne 3)

Same as previous test

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 34 at r4 (raw file):

    if ($ProductType -ne 3)
    {
        Break

lower 'b'

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 37 at r4 (raw file):

    }

    $Installed = (Get-WindowsFeature -Name FS-DFS-Namespace).Installed

Same as previous test

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 41 at r4 (raw file):

        Context 'Windows Features' {
            It 'Should have the DFS Namespace Feature Installed' {
                $Installed | Should Be $true

Same as previous test

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 45 at r4 (raw file):

        }
    }
    if ($Installed -eq $false)

Same as previous test

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 45 at r4 (raw file):

        }
    }
    if ($Installed -eq $false)

Blank row before this one

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 47 at r4 (raw file):

    if ($Installed -eq $false)
    {
        Break

lower 'b'

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 65 at r4 (raw file):

            ReferralPriorityRank         = 10
        }
        $NamespaceSplat = [PSObject]@{

Blank row before this one

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 70 at r4 (raw file):

            Ensure                       = $Namespace.Ensure
        }
        $NamespaceFolder = [PSObject]@{

Blank row before this one

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 79 at r4 (raw file):

            TimeToLive                   = 500
        }
        $NamespaceTarget = [PSObject]@{

Blank row before this one

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 89 at r4 (raw file):

        Describe "MSFT_xDFSNamespaceFolder\Get-TargetResource" {

remove blank row

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 91 at r4 (raw file):

            Context 'Namespace Folder does not exist' {

remove blank row

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 99 at r4 (raw file):

                    $Result.Ensure | Should Be 'Absent'
                }
                It 'should call the expected mocks' {

Blank row before this one

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 106 at r4 (raw file):

            Context 'Namespace Folder does exist but Target does not' {

remove blank row

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 124 at r4 (raw file):

                }
                It 'should call the expected mocks' {

Blank row before this one

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 148 at r4 (raw file):

                    $Result.ReferralPriorityRank         | Should Be $NamespaceTarget.ReferralPriorityRank
                }
                It 'should call the expected mocks' {

Blank row before this one

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 156 at r4 (raw file):

        Describe "MSFT_xDFSNamespaceFolder\Set-TargetResource" {

remove blank row

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 164 at r4 (raw file):

            Context 'Namespace Folder does not exist but should' {

remove blank row

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 174 at r4 (raw file):

                    } | Should Not Throw
                }
                It 'should call expected Mocks' {

Blank row before this one

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 186 at r4 (raw file):

            Context 'Namespace Folder exists and should but Target does not' {

remove blank row

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 196 at r4 (raw file):

                    } | Should Not Throw
                }
                It 'should call expected Mocks' {

Blank row before this one

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 208 at r4 (raw file):

            Context 'Namespace Folder exists and should but has a different Description' {

blank row

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 219 at r4 (raw file):

                    } | Should Not Throw
                }
                It 'should call expected Mocks' {

Blank row before this one

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 231 at r4 (raw file):

            Context 'Namespace Folder exists and should but has a different TimeToLiveSec' {

remove blank row, and the same for the rest throughout the tests (and also maybe all other unit tests)

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 242 at r4 (raw file):

                    } | Should Not Throw
                }
                It 'should call expected Mocks' {

Blank row before this one, and the same for the rest throughout the tests (and also maybe all other unit tests)

Comments from Reviewable

PlagueHO · 2017-05-19T19:50:57Z

Review status: 64 of 79 files reviewed at latest revision, 97 unresolved discussions.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/MSFT_xDFSNamespaceFolder.psm1, line 38 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Let's change it later in another PR. But you could make a issue for that so it doesn't get forgotten. :)

Done 😁 #29

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 15 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Doesn't seem to be fixed :)

Doh - sorry about that. Fixed now.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceFolder/en-us/MSFT_xDFSNamespaceFolder.strings.psd1, line 18 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This is not fixed either. :)

Again - sorry about that. This time fixed.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/MSFT_xDFSNamespaceRoot.psm1, line 585 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Missed this one :)

Right you are - sorry about that. Fixed.

Modules/xDFS/DSCResources/MSFT_xDFSNamespaceRoot/en-us/MSFT_xDFSNamespaceRoot.strings.psd1, line 19 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

You missed this one too :)

Again - sorry about that one :( fixed.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/1_Domain_MultipleTarget.ps1, line 24 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment block here (was to quick to resolve the first comment)

This time - sorry again - fixed.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 24 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

No comment block yet :)

This time - sorry again - fixed.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 38 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment still out of alignment

This time - sorry again - fixed.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/2_Domain_SingleTarget.ps1, line 50 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Comment still out of alignment. Eyes playing tricks on me, resolved this one to quickly too. 😆

This time - sorry again - fixed.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 38 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Still out of alignment :)

This time - sorry again - fixed.

Modules/xDFS/Examples/Resources/xDFSNamespaceRoot/3_Standalone_FQDN.ps1, line 46 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Still out of alignment :)

This time - sorry again - fixed.

Modules/xDFS/Examples/Resources/xDFSNamespaceServerConfiguration/1_Standalone_FQDN.ps1, line 38 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Still out of alignment :)

This time - sorry again - fixed.

Comments from Reviewable

PlagueHO · 2017-05-19T20:28:50Z

Hi @johlju - thanks again for all your help on this. I'll go through the other unit tests and apply your previous comments to them as well.

Review status: 56 of 83 files reviewed at latest revision, 98 unresolved discussions.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 26 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

$ProductType

$productType

Fixed - did a global Search/Replace in VSCode 😁

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 30 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

same as above

Fixed - did a global Search/Replace in VSCode 😁

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 34 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

same as above

Fixed - did a global Search/Replace in VSCode 😁

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 34 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 36 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

lower 'b'

Fixed - did a global Search/Replace in VSCode 😁

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 39 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

$Installed

$featureInstalled or $featureFsDfsNamespaceInstalled

Fixed - did a global Search/Replace in VSCode 😁

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 43 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

same as above

Fixed - did a global Search/Replace in VSCode 😁

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 47 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

same as above

Fixed - did a global Search/Replace in VSCode 😁

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 49 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

lower 'b'

Fixed - did a global Search/Replace in VSCode 😁

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 60 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one. It just a personal preference for it to be easier to read and review the code.

Done.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 63 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one.

Done.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 67 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one.

Done.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 69 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one.

Done.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 72 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one.

Done.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 76 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one.

Done.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 116 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one.

Done.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 120 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one.

Done.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 123 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one.

Done.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 127 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one.

Done.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 130 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one.

Done.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 26 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

$ProductType

$productType

Done.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 30 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

same as above

Done.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 34 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

same as above

Done.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 34 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one.

Done.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 36 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

lower 'b'

Done.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 39 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

$Installed

$featureInstalled or $featureFsDfsNamespaceInstalled

Done.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 43 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

same as above

Done.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 47 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

same as above

Done.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 47 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

blank row here

Done.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 49 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

lower 'b'

Done.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 60 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one.

Done.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 63 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one.

Done.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 91 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one. Or shouldn't this be a separate IT-block?

Done. Split into two It blocks

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 104 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one.

Done.

Tests/Integration/MSFT_xDFSNamespaceRoot.Integration.Tests.ps1, line 107 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one.

Done.

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 26 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Same as previous tests

Done.

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 30 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Same as previous tests

Done.

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 34 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Same as previous tests

Done.

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 36 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

lower 'b'

Done.

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 39 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Same as previous tests

Done.

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 43 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Same as previous tests

Done.

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 47 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Same as previous tests

Done.

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 47 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Integration/MSFT_xDFSNamespaceServerConfiguration.Integration.Tests.ps1, line 49 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

lower 'b'

Done.

Tests/Integration/MSFT_xDFSReplicationGroup.Integration.Tests.ps1, line 78 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Integration/MSFT_xDFSReplicationGroup.Integration.Tests.ps1, line 94 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Integration/MSFT_xDFSReplicationGroup.Integration.Tests.ps1, line 102 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Integration/MSFT_xDFSReplicationGroup.Integration.Tests.ps1, line 112 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Integration/MSFT_xDFSReplicationGroupConnection.Integration.Tests.ps1, line 70 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Integration/MSFT_xDFSReplicationGroupConnection.Integration.Tests.ps1, line 76 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Integration/MSFT_xDFSReplicationGroupConnection.Integration.Tests.ps1, line 94 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Integration/MSFT_xDFSReplicationGroupFolder.Integration.Tests.ps1, line 70 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Integration/MSFT_xDFSReplicationGroupFolder.Integration.Tests.ps1, line 76 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Integration/MSFT_xDFSReplicationGroupFolder.Integration.Tests.ps1, line 94 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Integration/MSFT_xDFSReplicationGroupMembership.Integration.Tests.ps1, line 70 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Integration/MSFT_xDFSReplicationGroupMembership.Integration.Tests.ps1, line 76 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Integration/MSFT_xDFSReplicationGroupMembership.Integration.Tests.ps1, line 94 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 24 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

$ProductType

Same as previous test

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 28 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Same as previous test

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 32 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 32 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Same as previous test

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 34 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

lower 'b'

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 37 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Same as previous test

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 41 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Same as previous test

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 45 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Same as previous test

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 45 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 47 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

lower 'b'

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 65 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 70 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 79 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 89 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

remove blank row

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 91 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

remove blank row

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 99 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 106 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

remove blank row

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 124 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 148 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 156 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

remove blank row

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 164 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

remove blank row

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 174 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 186 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

remove blank row

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 196 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 208 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

blank row

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 219 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 231 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

remove blank row, and the same for the rest throughout the tests (and also maybe all other unit tests)

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 242 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Blank row before this one, and the same for the rest throughout the tests (and also maybe all other unit tests)

Done. All other unit tests have the same issue - so fixing them!

Comments from Reviewable

PlagueHO · 2017-05-19T20:59:41Z

Ok @johlju - I think I've made all the changes to the other unit tests to match your previous comments. Thank you again!

Review status: 56 of 83 files reviewed at latest revision, 97 unresolved discussions.

Comments from Reviewable

johlju · 2017-05-20T06:09:26Z

All files reviewed. We probably missed something somewhere, but I think you done an awesome job here! 😄

Just a few small comments left :)

Reviewed 3 of 94 files at r1, 27 of 27 files at r5.
Review status: all files reviewed at latest revision, 16 unresolved discussions, some commit checks broke.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 34 at r4 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Done.

No blank row yet ;)

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 242 at r4 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Done. All other unit tests have the same issue - so fixing them!

I guessed you would fix all the test so it would simplify my review today 😄 Awesome work with this PR!!

Tests/Unit/MSFT_xDFSNamespaceRoot.Tests.ps1, line 763 at r5 (raw file):

                It 'should return null' {

Remove blank row here

Tests/Unit/MSFT_xDFSNamespaceRoot.Tests.ps1, line 778 at r5 (raw file):

                It 'should return the expected root' {

Remove blank row here

Tests/Unit/MSFT_xDFSNamespaceRoot.Tests.ps1, line 819 at r5 (raw file):

                It 'should return the expected target' {

Remove blank row here

Tests/Unit/MSFT_xDFSNamespaceServerConfiguration.Tests.ps1, line 54 at r5 (raw file):

    #region Pester Tests
    InModuleScope $script:DSCResourceName {

Remove blank row here

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 83 at r5 (raw file):

            Ensure = 'Present'
            Description = 'Test Description'
            Members = @('FileServer1.CONTOSO.COM','FileServer2.CONTOSO.COM')

Extremely minor: But shouldn't '.contoso.com' be written with lower-case letters? (throughout the file if so)

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 675 at r5 (raw file):

                        $SourceComputerName -eq "$($replicationGroupConnections[0].SourceComputerName).$($replicationGroupConnections[0].DomainName)"
                    }
                Mock Get-DfsrConnection `

Add blank row before this one

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 680 at r5 (raw file):

                        $SourceComputerName -eq "$($replicationGroupConnections[1].SourceComputerName).$($replicationGroupConnections[1].DomainName)"
                    }
                Mock Add-DfsrConnection

Minor: Move these up to the other "simple mocks" so they can be grouped together

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 724 at r5 (raw file):

                        $SourceComputerName -eq "$($replicationGroupConnections[0].SourceComputerName).$($replicationGroupConnections[0].DomainName)"
                    }
                Mock Get-DfsrConnection `

Add blank row before this one

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 729 at r5 (raw file):

                        $SourceComputerName -eq "$($replicationGroupConnections[1].SourceComputerName).$($replicationGroupConnections[1].DomainName)"
                    }
                Mock Add-DfsrConnection

Minor: Move these up to the other "simple mocks" so they can be grouped together

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 773 at r5 (raw file):

                        $SourceComputerName -eq "$($replicationGroupConnections[0].SourceComputerName).$($replicationGroupConnections[0].DomainName)"
                    }
                Mock Get-DfsrConnection `

Add blank row before this one

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 778 at r5 (raw file):

                        $SourceComputerName -eq "$($replicationGroupConnections[1].SourceComputerName).$($replicationGroupConnections[1].DomainName)"
                    }
                Mock Add-DfsrConnection

Minor: Move these up to the other "simple mocks" so they can be grouped together

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 1105 at r5 (raw file):

                        $SourceComputerName -eq "$($replicationGroupConnections[0].SourceComputerName).$($replicationGroupConnections[0].DomainName)"
                    }
                Mock Get-DfsrConnection `

Add blank row before this one

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 1134 at r5 (raw file):

                        $SourceComputerName -eq "$($replicationGroupConnections[0].SourceComputerName).$($replicationGroupConnections[0].DomainName)"
                    }
                Mock Get-DfsrConnection `

Add blank row before this one

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 1193 at r5 (raw file):

                        $SourceComputerName -eq "$($replicationGroupConnections[0].SourceComputerName).$($replicationGroupConnections[0].DomainName)"
                    }
                Mock Get-DfsrConnection `

Add blank row before this one

Comments from Reviewable

PlagueHO · 2017-05-20T09:47:38Z

Woop! All done (hopefully 😁). Thanks again @johlju !

Review status: 67 of 83 files reviewed at latest revision, 15 unresolved discussions.

Tests/Integration/MSFT_xDFSNamespaceFolder.Integration.Tests.ps1, line 34 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

No blank row yet ;)

Done.

Tests/Unit/MSFT_xDFSNamespaceFolder.Tests.ps1, line 242 at r4 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

I guessed you would fix all the test so it would simplify my review today 😄 Awesome work with this PR!!

I'll generally try and apply any PR comments to all files to save you time - so if you notice something, just let me know the first occurrence and I'll go through and make sure the rest are done. 😁

Tests/Unit/MSFT_xDFSNamespaceRoot.Tests.ps1, line 763 at r5 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Remove blank row here

Done.

Tests/Unit/MSFT_xDFSNamespaceRoot.Tests.ps1, line 778 at r5 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Remove blank row here

Done.

Tests/Unit/MSFT_xDFSNamespaceRoot.Tests.ps1, line 819 at r5 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Remove blank row here

Done.

Tests/Unit/MSFT_xDFSNamespaceServerConfiguration.Tests.ps1, line 54 at r5 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Remove blank row here

Done.

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 83 at r5 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Extremely minor: But shouldn't '.contoso.com' be written with lower-case letters? (throughout the file if so)

I did a global search replace on this one too. So all now in lower case.

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 675 at r5 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Add blank row before this one

Done.

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 680 at r5 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Minor: Move these up to the other "simple mocks" so they can be grouped together

Done.

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 724 at r5 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Add blank row before this one

Done.

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 729 at r5 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Minor: Move these up to the other "simple mocks" so they can be grouped together

Done.

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 773 at r5 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Add blank row before this one

Done.

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 778 at r5 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Minor: Move these up to the other "simple mocks" so they can be grouped together

Done.

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 1105 at r5 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Add blank row before this one

Done.

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 1134 at r5 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Add blank row before this one

Done.

Tests/Unit/MSFT_xDFSReplicationGroup.Tests.ps1, line 1193 at r5 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

Add blank row before this one

Done.

Comments from Reviewable

johlju · 2017-05-20T13:13:37Z

Reviewed 16 of 16 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

PlagueHO · 2017-05-21T00:50:47Z

Awesome! You rock @johlju

Will merge now!

PlagueHO added 16 commits January 21, 2017 20:10

Converted AppVeyor build process to use AppVeyor.yml.

0ac4deb

* Converted AppVeyor build process to use AppVeyor.yml.

0684734

* Resolved PSSA violations. * Resolved Readme.md style violations. * Converted Integration Tests to use Test Drive and stop using Invoke-Pester.

Fix up Integration tests

4a58d39

Fix integration tests

00ab52e

Fix AppVeyor layout

2c48165

Fix last integration tests

8c93e75

* Move strings into separate language files.

1e367d8

* Added CodeCov support.

Fix up AppVeyor call names

64679d3

Fix up

c50ff40

Fix up corruption

358f00d

Convert to Wiki and AutoDocumentation and TestHarness methods

c39756b

Change completed but untested

c4b0fbf

Tweak manifest to try and get tests passing

83f4607

Fix some copy/paste errors

129ebdd

Fix up Example generation

2971eb1

Correct changelog

5a31990

msftclas added the cla-already-signed label Feb 21, 2017

PlagueHO added the needs review The pull request needs a code review. label Feb 21, 2017

dscottraynsford added 8 commits April 29, 2017 19:16

Worked on making the parameter blocks meet the guidelines

f3f2df3

Fix type accelerators

32b44ca

Making changes to meet HQRM guidelines

dda31e6

Updated Readme.md to meet standards

8d9cbd3

Fix unit tests

f92e811

More changes to meet HQRM

618878b

More work on HQRM

751e732

More changes to meet HQRM

73c0c47

First cut at PR fixes

e1861a6

dscottraynsford added 2 commits May 19, 2017 20:59

More work on PR

5945836

Fix unit tests after PR work

8b12d09

dscottraynsford added 3 commits May 19, 2017 21:29

More changes as per PR comments

89dd31e

Nearly completed PR changes

44f5ab9

All PR comments done I think

dc21a49

Fix unit tests

17f0243

Fix missed PR comments

0e783e4

dscottraynsford added 2 commits May 20, 2017 08:20

More changes from PR comments

86e54c4

More PR changes

cb0afa4

dscottraynsford added 2 commits May 20, 2017 08:47

Correct unit test style

f2ba2b8

Final fixes and changes to unit tests

167e595

Fixes as per PR comments

4c74332

PlagueHO merged commit ba71a65 into dsccommunity:dev May 21, 2017

vors removed the needs review The pull request needs a code review. label May 21, 2017

PlagueHO deleted the Use-AppVeyor-Module branch May 21, 2017 00:50

This was referenced May 21, 2017

Upgrade to meet HQRM Guidelines #21

Closed

Add CommonResourceHelper.psm1 module and update to use it #22

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Converted to use Wiki Auto Documentation, Appveyor Shared Code and HQRM - Fixes #25 #26

Converted to use Wiki Auto Documentation, Appveyor Shared Code and HQRM - Fixes #25 #26

PlagueHO commented Feb 21, 2017 •

edited

codecov-io commented Feb 21, 2017 •

edited

PlagueHO commented Apr 27, 2017

johlju commented Apr 27, 2017

PlagueHO commented Apr 28, 2017

PlagueHO commented May 19, 2017

Installation

PlagueHO commented May 19, 2017

PlagueHO commented May 19, 2017

johlju commented May 19, 2017

johlju commented May 19, 2017

PlagueHO commented May 19, 2017

PlagueHO commented May 19, 2017

PlagueHO commented May 19, 2017

johlju commented May 20, 2017

PlagueHO commented May 20, 2017

johlju commented May 20, 2017

PlagueHO commented May 21, 2017

Converted to use Wiki Auto Documentation, Appveyor Shared Code and HQRM - Fixes #25 #26

Converted to use Wiki Auto Documentation, Appveyor Shared Code and HQRM - Fixes #25 #26

Conversation

PlagueHO commented Feb 21, 2017 • edited

codecov-io commented Feb 21, 2017 • edited

Codecov Report

PlagueHO commented Apr 27, 2017

johlju commented Apr 27, 2017

PlagueHO commented Apr 28, 2017

PlagueHO commented May 19, 2017

Installation

PlagueHO commented May 19, 2017

PlagueHO commented May 19, 2017

johlju commented May 19, 2017

johlju commented May 19, 2017

PlagueHO commented May 19, 2017

PlagueHO commented May 19, 2017

PlagueHO commented May 19, 2017

johlju commented May 20, 2017

PlagueHO commented May 20, 2017

johlju commented May 20, 2017

PlagueHO commented May 21, 2017

PlagueHO commented Feb 21, 2017 •

edited

codecov-io commented Feb 21, 2017 •

edited