Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use template files #12

Merged
merged 2 commits into from
Sep 22, 2018
Merged

Update to use template files #12

merged 2 commits into from
Sep 22, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented Sep 22, 2018

Pull Request (PR) description

  • Update appveyor.yml to use the default template.
  • Added default template files .codecov.yml, .gitattributes, and .gitignore, and
    .vscode folder.
  • The module manifest now contain the correct PowerShell version.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the README.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit d9370ad into dev Sep 22, 2018
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (dev@f6445fb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##             dev   #12   +/-   ##
===================================
  Coverage       ?    0%           
===================================
  Files          ?     1           
  Lines          ?     8           
  Branches       ?     0           
===================================
  Hits           ?     0           
  Misses         ?     8           
  Partials       ?     0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6445fb...c310420. Read the comment docs.

@johlju johlju deleted the add-template branch September 22, 2018 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants