Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

condition Class != Potion causes crash #34

Open
qqkookie opened this issue Nov 24, 2022 · 3 comments
Open

condition Class != Potion causes crash #34

qqkookie opened this issue Nov 24, 2022 · 3 comments

Comments

@qqkookie
Copy link

qqkookie commented Nov 24, 2022

It seems that the condition Class != Potion or similar Class != expression causes hard crash on loading the filter file.
Type != Super Healing Potion does not cause crash.
And Class condition with non-existent class (due to spell error etc) always success and issues no error message. It make hard to track down error. Non existing class condition should issue warning.

@qqkookie qqkookie changed the title condition Class != Potion cause crash condition Class != Potion causes crash Nov 24, 2022
@dschu012
Copy link
Owner

This is an incomplete project, I lost time and interest. But the following is in the readme

* Error handling. Filter just silently ignores errors right now.

It's known that errors are ignored. To track down issues I suggest using the /debug and/or the /test features.

@qqkookie
Copy link
Author

qqkookie commented Nov 28, 2022

Hmmm.. then may I edit and revise the source code more widely? i.e. not just small fix, but more revisions and improvement of basic functionalities of d2lootfilter and source code. I'd like to add most of improvements I suggested in the #31 by myself. If you are no longer interested in maintaining this project, I can volunteer.

@dschu012
Copy link
Owner

You're welcome to fork it and change it to your will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants