Incorrect selectors for querySelectorAll

[nin-jin]

Uncaught DOMException: Failed to execute 'querySelectorAll' on 'Document': '#$mol_app_todomvc.Root(0).Title()' is not a valid selector.

App: https://mol.js.org/app/todomvc/

You should use getElementById:

document.getElementById('$mol_app_todomvc.Root(0).Task_row(1).Title()')

Or use right escaping:

document.querySelector('#\\$mol_app_todomvc\\.Root\\(0\\)\\.Task_row\\(1\\)\\.Title\\(\\)')

[dsheiko]

Thanks, a nice one. It gets included in v3.0.1

[nin-jin]

When will it be?

[dsheiko]

I believe in a week, want to collect other possible issues for the release

[nin-jin]

I really want to try puppetry. But I can't until this fix are released.

[dsheiko]

But as I understand, you built Puppetry when testing the fix. So you can run it like "npm start". I need extra checks before releasing the last changes.
You can also build it on your own with:
npm run dist:all
it creates dist folder with builds per platform

[nin-jin]

But as I understand, you built Puppetry when testing the fix.

Nope. :-)

[dsheiko]

You can play with dev version https://we.tl/t-jyrOwDnXGu

[nin-jin]

Yeah, it works. But could you make custom names for selectors are optional? It completely useless for me, because ids is already readable.

[dsheiko]

Oops, didn't get it. Recorder tries to suggest a passing name automatically. Optionally you can right-click on a target and specify a custom name.

[nin-jin]

I don't want to name selectors (so for assertion I have no choice), I want to use selector itself (but without escaping of course).

[dsheiko]

In your particular case it's so, but usually the selectors are like "div > div:nth-child(2) > div:nth-child(2) > div:nth-child(2) > div:nth-child(2)". Too long for searching in select and meaningless. You can rename targets as you wish. When editing as CSV (as a text) you can use any tools for bulk renaming.

[nin-jin]

"div > div:nth-child(2) > div:nth-child(2) > div:nth-child(2) > div:nth-child(2)" is too fragile selectors. So in my architecture all elements have user-readable stable semantic id's. I don't want fragile selectors. So I don't want to name or rename selectors. I want selectors naming to be totally optional.