fix: escape escapes in .quote() #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegohaz
pushed a commit
to ariakit/ariakit
that referenced
this pull request
Mar 10, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ts-morph](https://togithub.com/dsherret/ts-morph) | [`21.0.1` -> `22.0.0`](https://renovatebot.com/diffs/npm/ts-morph/21.0.1/22.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dsherret/ts-morph (ts-morph)</summary> ### [`v22.0.0`](https://togithub.com/dsherret/ts-morph/releases/tag/22.0.0) [Compare Source](https://togithub.com/dsherret/ts-morph/compare/21.0.1...22.0.0) #### What's Changed - feat(BREAKING): upgrade to TypeScript 5.4 by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1516 - fix(BREAKING): `Node.prototype.forgetDescendants()` no longer returns self by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1515 - feat: `Type.prototype.isAssignableTo` by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1517 - feat: `TypeChecker.prototype.resolveName` by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1518 - fix: MethodDeclarationStructure should write an asterisk isGenerator = true by [@​ajvincent](https://togithub.com/ajvincent) in [dsherret/ts-morph#1502 - docs: fix typo in adding-source-files.md by [@​ilirbeqirii](https://togithub.com/ilirbeqirii) in [dsherret/ts-morph#1490 - feat: ClassDeclarationStructure - support static blocks by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1520 ##### CodeBlockWriter 13.0.1 People may have been working around these bugs in the past: - `.quote()` - should include newline on newline ([dsherret/code-block-writer#47) - `.quote()` - escape characters were not always being escaped ([dsherret/code-block-writer#46) #### New Contributors - [@​ilirbeqirii](https://togithub.com/ilirbeqirii) made their first contribution in [dsherret/ts-morph#1490 **Full Changelog**: dsherret/ts-morph@21.0.1...22.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ariakit/ariakit). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
added a commit
to ScaleLeap/selling-partner-api-sdk
that referenced
this pull request
Apr 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ts-morph](https://togithub.com/dsherret/ts-morph) | [`21.0.1` -> `22.0.0`](https://renovatebot.com/diffs/npm/ts-morph/21.0.1/22.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dsherret/ts-morph (ts-morph)</summary> ### [`v22.0.0`](https://togithub.com/dsherret/ts-morph/releases/tag/22.0.0) [Compare Source](https://togithub.com/dsherret/ts-morph/compare/21.0.1...22.0.0) #### What's Changed - feat(BREAKING): upgrade to TypeScript 5.4 by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1516 - fix(BREAKING): `Node.prototype.forgetDescendants()` no longer returns self by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1515 - feat: `Type.prototype.isAssignableTo` by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1517 - feat: `TypeChecker.prototype.resolveName` by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1518 - fix: MethodDeclarationStructure should write an asterisk isGenerator = true by [@​ajvincent](https://togithub.com/ajvincent) in [dsherret/ts-morph#1502 - docs: fix typo in adding-source-files.md by [@​ilirbeqirii](https://togithub.com/ilirbeqirii) in [dsherret/ts-morph#1490 - feat: ClassDeclarationStructure - support static blocks by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1520 ##### CodeBlockWriter 13.0.1 People may have been working around these bugs in the past: - `.quote()` - should include newline on newline ([dsherret/code-block-writer#47) - `.quote()` - escape characters were not always being escaped ([dsherret/code-block-writer#46) #### New Contributors - [@​ilirbeqirii](https://togithub.com/ilirbeqirii) made their first contribution in [dsherret/ts-morph#1490 **Full Changelog**: dsherret/ts-morph@21.0.1...22.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ScaleLeap/selling-partner-api-sdk). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In quote(), it should escape escapes. So for example, if you provide something like:
It should output:
Rather than:
I'm going to do a major release for this bug because a patch might break people.