New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: MethodDeclarationStructure should write an asterisk isGenerator = true #1502
fix: MethodDeclarationStructure should write an asterisk isGenerator = true #1502
Conversation
Huh, I don't see how my change could've broken the build. But I will note the |
parameters: [{ name: "p", type: "number" }], | ||
returnType: "number", | ||
scope: undefined, | ||
statements: ["return Promise.resolve(p);"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops. This shouldn't have been in this "isAbstract" test, but it's a good catch point, and it did pass on my build!
…he repo very soon)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ts-morph](https://togithub.com/dsherret/ts-morph) | [`21.0.1` -> `22.0.0`](https://renovatebot.com/diffs/npm/ts-morph/21.0.1/22.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/ts-morph/22.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/ts-morph/22.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/ts-morph/21.0.1/22.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/ts-morph/21.0.1/22.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dsherret/ts-morph (ts-morph)</summary> ### [`v22.0.0`](https://togithub.com/dsherret/ts-morph/releases/tag/22.0.0) [Compare Source](https://togithub.com/dsherret/ts-morph/compare/21.0.1...22.0.0) #### What's Changed - feat(BREAKING): upgrade to TypeScript 5.4 by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1516 - fix(BREAKING): `Node.prototype.forgetDescendants()` no longer returns self by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1515 - feat: `Type.prototype.isAssignableTo` by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1517 - feat: `TypeChecker.prototype.resolveName` by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1518 - fix: MethodDeclarationStructure should write an asterisk isGenerator = true by [@​ajvincent](https://togithub.com/ajvincent) in [dsherret/ts-morph#1502 - docs: fix typo in adding-source-files.md by [@​ilirbeqirii](https://togithub.com/ilirbeqirii) in [dsherret/ts-morph#1490 - feat: ClassDeclarationStructure - support static blocks by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1520 ##### CodeBlockWriter 13.0.1 People may have been working around these bugs in the past: - `.quote()` - should include newline on newline ([dsherret/code-block-writer#47) - `.quote()` - escape characters were not always being escaped ([dsherret/code-block-writer#46) #### New Contributors - [@​ilirbeqirii](https://togithub.com/ilirbeqirii) made their first contribution in [dsherret/ts-morph#1490 **Full Changelog**: dsherret/ts-morph@21.0.1...22.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ariakit/ariakit). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ts-morph](https://togithub.com/dsherret/ts-morph) | [`21.0.1` -> `22.0.0`](https://renovatebot.com/diffs/npm/ts-morph/21.0.1/22.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/ts-morph/22.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/ts-morph/22.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/ts-morph/21.0.1/22.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/ts-morph/21.0.1/22.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dsherret/ts-morph (ts-morph)</summary> ### [`v22.0.0`](https://togithub.com/dsherret/ts-morph/releases/tag/22.0.0) [Compare Source](https://togithub.com/dsherret/ts-morph/compare/21.0.1...22.0.0) #### What's Changed - feat(BREAKING): upgrade to TypeScript 5.4 by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1516 - fix(BREAKING): `Node.prototype.forgetDescendants()` no longer returns self by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1515 - feat: `Type.prototype.isAssignableTo` by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1517 - feat: `TypeChecker.prototype.resolveName` by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1518 - fix: MethodDeclarationStructure should write an asterisk isGenerator = true by [@​ajvincent](https://togithub.com/ajvincent) in [dsherret/ts-morph#1502 - docs: fix typo in adding-source-files.md by [@​ilirbeqirii](https://togithub.com/ilirbeqirii) in [dsherret/ts-morph#1490 - feat: ClassDeclarationStructure - support static blocks by [@​dsherret](https://togithub.com/dsherret) in [dsherret/ts-morph#1520 ##### CodeBlockWriter 13.0.1 People may have been working around these bugs in the past: - `.quote()` - should include newline on newline ([dsherret/code-block-writer#47) - `.quote()` - escape characters were not always being escaped ([dsherret/code-block-writer#46) #### New Contributors - [@​ilirbeqirii](https://togithub.com/ilirbeqirii) made their first contribution in [dsherret/ts-morph#1490 **Full Changelog**: dsherret/ts-morph@21.0.1...22.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ScaleLeap/selling-partner-api-sdk). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Fixes #1501 .