Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MethodDeclarationStructure should write an asterisk isGenerator = true #1502

Merged
merged 3 commits into from
Feb 11, 2024
Merged

fix: MethodDeclarationStructure should write an asterisk isGenerator = true #1502

merged 3 commits into from
Feb 11, 2024

Conversation

ajvincent
Copy link
Contributor

@ajvincent ajvincent commented Feb 5, 2024 •
edited

Fixes #1501 .

@ajvincent
Copy link
Contributor Author

Huh, I don't see how my change could've broken the build. But I will note the Memoize decorator is not written for the newer class decorators specification which TypeScript 5+ supports.

ajvincent
ajvincent commented Feb 5, 2024
View reviewed changes
packages/ts-morph/src/tests/structurePrinters/class/methodDeclarationStructurePrinterTests.ts
parameters: [{ name: "p", type: "number" }],
returnType: "number",
scope: undefined,
statements: ["return Promise.resolve(p);"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. This shouldn't have been in this "isAbstract" test, but it's a good catch point, and it did pass on my build!

@dsherret dsherret changed the title MethodDeclarationStructure should write an asterisk isGenerator = true fix: MethodDeclarationStructure should write an asterisk isGenerator = true Feb 11, 2024
dsherret
dsherret approved these changes Feb 11, 2024
View reviewed changes
Copy link
Owner

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsherret dsherret merged commit 871cb46 into dsherret:latest Feb 11, 2024
1 check passed
@ajvincent ajvincent deleted the MethodDeclarationStructure-isGenerator branch February 11, 2024 20:09
diegohaz pushed a commit to ariakit/ariakit that referenced this pull request Mar 10, 2024
@renovate
Update dependency ts-morph to v22 (#3568)
1f52a9d 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ts-morph](https://togithub.com/dsherret/ts-morph) | [`21.0.1` ->
`22.0.0`](https://renovatebot.com/diffs/npm/ts-morph/21.0.1/22.0.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/ts-morph/22.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/ts-morph/22.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/ts-morph/21.0.1/22.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/ts-morph/21.0.1/22.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>dsherret/ts-morph (ts-morph)</summary>

###
[`v22.0.0`](https://togithub.com/dsherret/ts-morph/releases/tag/22.0.0)

[Compare
Source](https://togithub.com/dsherret/ts-morph/compare/21.0.1...22.0.0)

#### What's Changed

- feat(BREAKING): upgrade to TypeScript 5.4 by
[@&#8203;dsherret](https://togithub.com/dsherret) in
[dsherret/ts-morph#1516
- fix(BREAKING): `Node.prototype.forgetDescendants()` no longer returns
self by [@&#8203;dsherret](https://togithub.com/dsherret) in
[dsherret/ts-morph#1515
- feat: `Type.prototype.isAssignableTo` by
[@&#8203;dsherret](https://togithub.com/dsherret) in
[dsherret/ts-morph#1517
- feat: `TypeChecker.prototype.resolveName` by
[@&#8203;dsherret](https://togithub.com/dsherret) in
[dsherret/ts-morph#1518
- fix: MethodDeclarationStructure should write an asterisk isGenerator =
true by [@&#8203;ajvincent](https://togithub.com/ajvincent) in
[dsherret/ts-morph#1502
- docs: fix typo in adding-source-files.md by
[@&#8203;ilirbeqirii](https://togithub.com/ilirbeqirii) in
[dsherret/ts-morph#1490
- feat: ClassDeclarationStructure - support static blocks by
[@&#8203;dsherret](https://togithub.com/dsherret) in
[dsherret/ts-morph#1520

##### CodeBlockWriter 13.0.1

People may have been working around these bugs in the past:

- `.quote()` - should include newline on newline
([dsherret/code-block-writer#47)
- `.quote()` - escape characters were not always being escaped
([dsherret/code-block-writer#46)

#### New Contributors

- [@&#8203;ilirbeqirii](https://togithub.com/ilirbeqirii) made their
first contribution in
[dsherret/ts-morph#1490

**Full Changelog**:
dsherret/ts-morph@21.0.1...22.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ariakit/ariakit).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to ScaleLeap/selling-partner-api-sdk that referenced this pull request Apr 3, 2024
@renovate
chore(deps): update dependency ts-morph to v22 (#1025)
43363b8 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ts-morph](https://togithub.com/dsherret/ts-morph) | [`21.0.1` ->
`22.0.0`](https://renovatebot.com/diffs/npm/ts-morph/21.0.1/22.0.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/ts-morph/22.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/ts-morph/22.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/ts-morph/21.0.1/22.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/ts-morph/21.0.1/22.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>dsherret/ts-morph (ts-morph)</summary>

###
[`v22.0.0`](https://togithub.com/dsherret/ts-morph/releases/tag/22.0.0)

[Compare
Source](https://togithub.com/dsherret/ts-morph/compare/21.0.1...22.0.0)

#### What's Changed

- feat(BREAKING): upgrade to TypeScript 5.4 by
[@&#8203;dsherret](https://togithub.com/dsherret) in
[dsherret/ts-morph#1516
- fix(BREAKING): `Node.prototype.forgetDescendants()` no longer returns
self by [@&#8203;dsherret](https://togithub.com/dsherret) in
[dsherret/ts-morph#1515
- feat: `Type.prototype.isAssignableTo` by
[@&#8203;dsherret](https://togithub.com/dsherret) in
[dsherret/ts-morph#1517
- feat: `TypeChecker.prototype.resolveName` by
[@&#8203;dsherret](https://togithub.com/dsherret) in
[dsherret/ts-morph#1518
- fix: MethodDeclarationStructure should write an asterisk isGenerator =
true by [@&#8203;ajvincent](https://togithub.com/ajvincent) in
[dsherret/ts-morph#1502
- docs: fix typo in adding-source-files.md by
[@&#8203;ilirbeqirii](https://togithub.com/ilirbeqirii) in
[dsherret/ts-morph#1490
- feat: ClassDeclarationStructure - support static blocks by
[@&#8203;dsherret](https://togithub.com/dsherret) in
[dsherret/ts-morph#1520

##### CodeBlockWriter 13.0.1

People may have been working around these bugs in the past:

- `.quote()` - should include newline on newline
([dsherret/code-block-writer#47)
- `.quote()` - escape characters were not always being escaped
([dsherret/code-block-writer#46)

#### New Contributors

- [@&#8203;ilirbeqirii](https://togithub.com/ilirbeqirii) made their
first contribution in
[dsherret/ts-morph#1490

**Full Changelog**:
dsherret/ts-morph@21.0.1...22.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" in timezone Etc/UTC,
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ScaleLeap/selling-partner-api-sdk).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MethodDeclarationStructure with isGenerator: true does not serialize with the asterisk
2 participants
@ajvincent @dsherret