Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manipulating a class in an ambient context #125

Closed
dsherret opened this issue Nov 12, 2017 · 3 comments
Closed

Manipulating a class in an ambient context #125

dsherret opened this issue Nov 12, 2017 · 3 comments

Comments

@dsherret
Copy link
Owner

Separating this out into its own task from #27.

@dsherret
Copy link
Owner Author

I think this is already done. Please open an issue if there's anything I forgot or comment here.

@derolf
Copy link

derolf commented Apr 17, 2018

Are you sure? I have an ambient module with classes. If I add a member function, I get “{}”, but I would expect just “;”.

dsherret added a commit that referenced this issue Apr 17, 2018
@dsherret
Copy link
Owner Author

@derolf thanks for bringing that to my attention! There was a bug where it wouldn't thoroughly check if it was in an ambient context when adding/inserting a class to an ambient module in a non-declaration file. This is released and should be fixed now in 10.3.3. I believe that was probably the issue you encountered? If not, could you submit a short example that shows the problem? Thanks!

dsherret added a commit that referenced this issue May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants