Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low priority manipulation tasks #27

Closed
7 tasks done
dsherret opened this issue Jun 5, 2017 · 5 comments
Closed
7 tasks done

Low priority manipulation tasks #27

dsherret opened this issue Jun 5, 2017 · 5 comments

Comments

@dsherret
Copy link
Owner

dsherret commented Jun 5, 2017

I'm going to use this issue to collect together some low priority manipulation tasks. I'll come back to implement these at the end.

ClassDeclaration

Decorator

  • Renaming - Edit: Won't do. Users can get the appropriate identifier and rename that.
  • Setting as a factory or not
  • Adding/inserting arguments

JSDoc

  • Setting description

Function/Methods/Constructors

  • Setting body text

VariableDeclarationList

  • Setting declaration type.

VariableStatement

  • Adding variable declarations

More to come...

@reda-alaoui
Copy link

reda-alaoui commented Nov 5, 2017

@dsherret ,

First, thank you for this amazing lib.

I am building a tool to upgrade a legacy javascript code to typescript.
Among the conversions, the tool must replace var with let declaration types everywhere.
I stumbled on:

Error: Filling variable declaration type not implemented. Please comment on issue #27 if you need this and I will increase the priority.

So here I am asking to increase Setting declaration type priority.
I can also make a PR if you give me some guidance.

@dsherret
Copy link
Owner Author

dsherret commented Nov 5, 2017

@reda-alaoui thanks, I'm glad it's useful for you!

It's very easy for me to add that. I'll start work on that now.

@reda-alaoui
Copy link

reda-alaoui commented Nov 5, 2017

Great! thank you :)

@dsherret
Copy link
Owner Author

dsherret commented Nov 5, 2017

@reda-alaoui this is implemented and available in v0.85.0.

I'm going to keep working on the other tasks in this issue.

@reda-alaoui
Copy link

You rock !

dsherret added a commit that referenced this issue Nov 6, 2017
- Getting JSDoc tags.

Need to update the documentation for this before releasing. Still a lot of JSDoc stuff not implemented.
dsherret added a commit that referenced this issue Nov 12, 2017
dsherret added a commit that referenced this issue Nov 12, 2017
- Setting decorator as factory or not
- Adding/inserting variable declarations to variable statement
- Adding/inserting arguments to decorators
dsherret added a commit that referenced this issue May 14, 2019
- Getting JSDoc tags.

Need to update the documentation for this before releasing. Still a lot of JSDoc stuff not implemented.
dsherret added a commit that referenced this issue May 14, 2019
dsherret added a commit that referenced this issue May 14, 2019
- Setting decorator as factory or not
- Adding/inserting variable declarations to variable statement
- Adding/inserting arguments to decorators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants