Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An unexpected keyword argument 'optimize' #48

Closed
liruiluo opened this issue Nov 15, 2022 · 1 comment
Closed

An unexpected keyword argument 'optimize' #48

liruiluo opened this issue Nov 15, 2022 · 1 comment

Comments

@liruiluo
Copy link

liruiluo commented Nov 15, 2022

Thanks for your excellent work, I have a question about the argument:
When I fixed the action of the first dimension as a symbolic policy on the "LunarLanderContinuous-v2" environment, the program reported an error:
TypeError: from_str_tokens() got an unexpected keyword argument 'optimize'
in control.py, line 193.
I ran successfully with "optimize" removed. However, the results of the run cannot reach the results in the paper (I get lower r_avg_test than 238 many times, while the paper is 251.66).
So I'm wondering how to run it successfully without removing "optimize" and get the results in the paper.

Here is my config file:
// This example contains the tuned entropy_weight and entropy_gamma
// hyperparameters used to solve LunarLanderContinuous-v2
{
"task" : {
"task_type" : "control",
"env" : "LunarLanderContinuous-v2",
"action_spec" : [["exp","cos","exp","mul","div","add","sub","add","add","add","exp", "add","add","add","add","x2","x4","x4","5.0","x4","1.0","x5","x4","x4 ","5.0","x4","x4"], null],
},
"training" : {
// Recommended to set this to as many cores as you can use!
"n_cores_batch" : 16
},
"controller" : {
"entropy_weight" : 0.02,
"entropy_gamma" : 0.85
},
}

@brendenpetersen
Copy link
Collaborator

Sorry for the delay on this. I don't think the optimize flag is going to make any difference here. DSO is stochastic, and the code has undergone some changes since the paper, so it's going to be hard to exactly reproduce those results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants