Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variable-length secrets #9

Closed
dsprenkels opened this issue Oct 19, 2017 · 4 comments
Closed

Support variable-length secrets #9

dsprenkels opened this issue Oct 19, 2017 · 4 comments

Comments

@dsprenkels
Copy link
Owner

dsprenkels commented Oct 19, 2017

Note: the idea is not to change the key length, only the XSalsa20 encrypted message. We should estimate whether we want to make this the default functionality, and if so, whether it's acceptable to break backwards-compatibility with the current API.

@dsprenkels
Copy link
Owner Author

A draft implementation is listed in https://github.com/dsprenkels/sss/tree/rwot8-variable-length. I am personally not convinced of the security of this code.

If somebody is willing to do a proper code review, and convince me the code is safe, I may be able to merge it.

@dsprenkels
Copy link
Owner Author

I will mark this a wontfix after 22 Aug. I will still include a guide on how to implement the wrapper yourself (though probably as part of the sss-rs repository).

@mhamann
Copy link

mhamann commented Jul 27, 2019

I could definitely use this feature, though I probably don't have the technical C/C++ chops to review your code.

@dsprenkels
Copy link
Owner Author

Closing this issue as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants