Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Allow privileged mode for docker on GCP #1403

Closed
rejuvyesh opened this issue Jul 7, 2024 · 4 comments
Closed

[Feature]: Allow privileged mode for docker on GCP #1403

rejuvyesh opened this issue Jul 7, 2024 · 4 comments

Comments

@rejuvyesh
Copy link

Problem

GCSFuse allows mounting a remote GCS bucket as a local filesystem and is a standard thing to do in HPC contexts. GoogleCloudPlatform/gcsfuse#566 means that mounting a fuse system inside docker requires running it in privileged mode. It seems current instance configuration chooses to not allow passing in any config to docker run.

Solution

For TPU support, dstack already enables privileged mode for the docker image. We just need to allow that to happen for standard GPUs on GCP as well.

Workaround

No response

Would you like to help us implement this feature by sending a PR?

Yes

@peterschmidt85
Copy link
Contributor

@rejuvyesh Could you please hardcode the privileged flag, run dstack server from sources, and see if this fixes the problem with GCSFuse?

If all works (it's is important to ensure this in advance), then we can find a way to make privileged configurable from the YAML configuration.

@peterschmidt85
Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity.

@rejuvyesh
Copy link
Author

Sorry, got busy with other things. Will likely have more time after next week.

@un-def
Copy link
Collaborator

un-def commented Oct 18, 2024

The privileged property is available since 0.18.18. If you still have issues with privileged: true in the run configuration, please open another issue with steps to reproduce.

@un-def un-def closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants