Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mpnum.special.sumup #27

Closed
dsuess opened this issue Dec 1, 2016 · 1 comment
Closed

Fix mpnum.special.sumup #27

dsuess opened this issue Dec 1, 2016 · 1 comment

Comments

@dsuess
Copy link
Owner

dsuess commented Dec 1, 2016 •
edited
Loading

The current implementation of mpnum.special.sumup is probably not the best. [1, Eq. (153)] suggests a more efficient algorithm for compression after summation. We should try it out.

[1] U. Schollwöck, “The density-matrix renormalization group in the age of matrix product states,” Annals of Physics, vol. 326, no. 1, pp. 96–192, Jan. 2011.
@dsuess dsuess changed the title Fix mpnum.special.sumup Fix mpnum.special.sumup Dec 1, 2016
@dsuess
Copy link
Owner Author

dsuess commented Jan 18, 2017 •
edited
Loading

Fixed in fc30ef3.

It's not exactly the sweeping-based solution proposed in [1], but it accomplishes a good scaling by using sparse matrices and (possibly) randomized truncated SVDs.

@dsuess dsuess closed this as completed Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsuess