Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to elkhound/Makefile.in #9

Merged
merged 1 commit into from
Nov 19, 2013
Merged

Conversation

robertmichaelwalsh
Copy link
Contributor

This fixes compilation issues under Linux. To be more specific, the call to gcc for the Bison-generated files was missing the include of the smbase and ast paths, whose header files are required.

There was also an issue with the initialiser for yyval, I have changed that line so that the initialiser is now (I think) safe for union types.

…inux. Also changed initialiser for yyval to one that is safe for union types.
@dsw
Copy link
Owner

dsw commented Nov 19, 2013

Robert, I looked at the diff and I don't see any changes that would
correspond to this comment: "To be more specific, the call to gcc for
the Bison-generated files was missing the include of the smbase and
ast paths, whose header files are required." Did you make a change
that added some #include lines but then not commit them? Or am I
missing something here?

Daniel

On Mon, Nov 18, 2013 at 4:41 AM, Robert Michael Walsh
notifications@github.com wrote:

This fixes compilation issues under Linux. To be more specific, the call to
gcc for the Bison-generated files was missing the include of the smbase and
ast paths, whose header files are required.

There was also an issue with the initialiser for yyval, I have changed that
line so that the initialiser is now (I think) safe for union types.


You can merge this Pull Request by running

git pull https://github.com/robertmichaelwalsh/oink-stack master

Or view, comment on, or merge it at:

#9

Commit Summary

GCC call for compiling Bison-generated files requires CCFLAGS under Linux.
Also changed initialiser for yyval to one that is safe for union types.

File Changes

M elkhound/Makefile.in (4)

Patch Links:

https://github.com/dsw/oink-stack/pull/9.patch
https://github.com/dsw/oink-stack/pull/9.diff

@dsw dsw merged commit de3c280 into dsw:master Nov 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants