Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and publish a PDF of the METexpress User's Guide #19

Closed
5 of 22 tasks
ksearight opened this issue Feb 24, 2021 · 17 comments · Fixed by #25
Closed
5 of 22 tasks

Create and publish a PDF of the METexpress User's Guide #19

ksearight opened this issue Feb 24, 2021 · 17 comments · Fixed by #25
Assignees
Labels
component: documentation Documentation issue priority: medium Medium Priority requestor: Community General Community type: task An actionable item of work

Comments

@ksearight
Copy link
Contributor

ksearight commented Feb 24, 2021

Replace italics below with details for this issue.

Describe the Task

As of METexpress-3.0.1, the User's Guide is created via Sphinx and the resulting html output is published to:
https://dtcenter.github.io/METexpress/development/Users_Guide/index.html

This task is to render the User's Guides as a PDF file which would useful for offline viewing. Some users, particularly in secure areas, do not have ready access to the internet for viewing docs on github.io. There is a PDF version for 3.0.1 currently available on dtcenter.org, but this was created from a Word document, not the Sphinx rst files.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of development.
    Branch name: feature_19_pdf_doc
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into development.
    Pull request: feature 19 PDF Doc
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@ksearight ksearight added the type: task An actionable item of work label Feb 24, 2021
@ksearight ksearight self-assigned this Feb 24, 2021
@ksearight ksearight added component: documentation Documentation issue priority: medium Medium Priority requestor: Community General Community labels Feb 24, 2021
@ksearight ksearight added this to the METexpress 4.0.0 milestone Feb 24, 2021
@ksearight
Copy link
Contributor Author

ksearight commented Mar 3, 2021

This is the development version of the PDF generated from Sphinx rst files METexpress_Users_Guide_vdevelopment.pdf to be reviewed.
For reference, here is the currently published PDF, created from MS Word: METexpress Users Guide.pdf.

A few points about the generated PDF:

  1. There is a TOC, but not a cover page
  2. There is no index, it just has "genindex" and "search" at the end of the document
  3. Page numbers are in the lower left
  4. The sections and figures are not numbered
  5. Long code blocks have smaller font sizes rather than wrapping.

@bonnystrong @jprestop I haven't found a way to resolve these formatting issues and differences, so my question is whether or not this formatting is sufficient "as is" for the next release version of the User Guide or not. It may be necessary to edit the rst files, which may affect the HTML version of the document as well. Please add your comments and opinions on "doneness" for this.

@bonnystrong
Copy link

bonnystrong commented Mar 3, 2021 via email

@jprestop
Copy link
Contributor

jprestop commented Mar 3, 2021

@ksearight Thanks so much for the links to both PDFs. It was helpful to do a comparison. I don't have a problem with the sections not being numbered. I think the size of the text and the table of contents denotes the levels of headers. One thing I noticed was that the text refers to figure numbers (e.g. Figure 3.6), but the figures aren't labelled. If we can't get the figures to be labelled, we could consider replacing the text "Figure 3.6", for example, with the text that does show up under the figure and put it in quotes or something like that.

@bonnystrong
Copy link

bonnystrong commented Mar 3, 2021 via email

@jprestop
Copy link
Contributor

jprestop commented Mar 3, 2021

@bonnystrong That is certainly understandable. I do feel that headers would make it much easier to follow.

@ksearight
Copy link
Contributor Author

I've retooled the PDF creation to use ReadTheDocs attached here.

This version fixes the following problems in the previous rst2pdf version:

  1. Sections and figures are numbered now, using the same numbering as in the HTML.
  2. It now has a cover page, including the METexpress logo
  3. Page numbers alternate on the lower left and right corners, which is formatted for printing
  4. Long code blocks are wrapped now.

@bonnystrong @jprestop Please review the new PDF and let me know if this meets the criteria to be released.

@jprestop
Copy link
Contributor

@ksearight Wow! This is great. I look forward to hearing how you managed to get the table of contents in place. I believe this meets the criteria for release, but will leave the decision up to @bonnystrong and the METexpress team. Thanks for all of your work on this!

@bonnystrong
Copy link

bonnystrong commented Mar 20, 2021 via email

@mollybsmith-noaa
Copy link
Collaborator

mollybsmith-noaa commented Mar 20, 2021 via email

@ksearight
Copy link
Contributor Author

@bonnystrong Thanks for reviewing. Here are responses to your findings:

  • I'll see if the blank space on p. 26 & 52 can be fixed in the rst files.
  • I think the blank pages on p. 54 & 58 are intentional by ReadThe Docs so that new chapters always begin on an odd numbered page. Formatting it that way will always put new chapters on the front side of the paper when printed double-sided. I don't know if that can be turned off or not.
  • I'll see if the index chapter can be skipped for PDFs. This is happening for the METplus user guide too.

@mollybsmith-noaa I'll merge your changes from development back into my feature branch and regenerate the doc so we see how it looks in PDF.

@mollybsmith-noaa
Copy link
Collaborator

mollybsmith-noaa commented Mar 22, 2021 via email

@ksearight
Copy link
Contributor Author

Here's an updated version of the PDF. I made these changes:

  1. Reduced the blank lines with rst file changes. It also changed the appearance in the HTML version slightly.
  2. Commented out the "Indices and tables" section in the rst file. It no longer appears in the HTML version either, but in the ReadTheDocs build, those links went to empty pages anyway.
  3. Merged in changes made to the development branch.

@bonnystrong @mollybsmith-noaa Please take a look and let me know what you think.

@mollybsmith-noaa
Copy link
Collaborator

mollybsmith-noaa commented Mar 23, 2021 via email

@bonnystrong
Copy link

bonnystrong commented Mar 23, 2021 via email

@randytpierce
Copy link
Collaborator

randytpierce commented Mar 23, 2021 via email

@ksearight
Copy link
Contributor Author

I changed the Appendix A to show the emc link instead of "here". I think it's ready for a pull request now.

@mollybsmith-noaa
Copy link
Collaborator

mollybsmith-noaa commented Mar 23, 2021 via email

@ksearight ksearight linked a pull request Mar 25, 2021 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Documentation issue priority: medium Medium Priority requestor: Community General Community type: task An actionable item of work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants