Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #401 replaced line_logger with logger in line 698 #402

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Issue #401 replaced line_logger with logger in line 698 #402

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
def68ed
Issue #401 replaced line_logger with logger in line 698
bikegeek Nov 2, 2023
7313a84
issue #401 don't remove the nan.points1 plot as cleanup
bikegeek Nov 2, 2023
b95be64
Issue #401 move this file from the intermediate files directory. It …
bikegeek Nov 3, 2023
fb4e157
issue #401 refer to the nan.points1 in a new directory
bikegeek Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metplotpy/plots/line/line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ def write_html(self) -> None:
# save html
self.figure.write_html(html_name, include_plotlyjs=False)

self.line_logger.info(f"Finished writing to html file: {datetime.now()}")
logger.info(f"Finished writing to html file: {datetime.now()}")

def write_output_file(self) -> None:
"""
Expand Down
1 change: 0 additions & 1 deletion test/line/test_line_plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ def test_no_nans_in_points_files():
os.remove(os.path.join(path, plot_file))
os.remove(os.path.join(intermed_path, points_file_1))
os.remove(os.path.join(intermed_path, points_file_2))
os.remove("./intermed_files/nan.points1")
except OSError as e:
# Typically when files have already been removed or
# don't exist. Ignore.
Expand Down