This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
adding an -npad option to discard padded dupes #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the `-npad, --no-padding` option to discard duplicate frames that are padded at the end of video segments. This is useful to create smoother transitions between subregions at the expense of having a video with a correct expected duration.
Regions with 1 frame should always be written out at least once.
Missed this in a merge.
This commit refactors, adds logs debugging information, and fixes multiple problems with the render module - most importantly an issue where Butterflow was not making enough interpolated frames. This led to duping the final frame in every segment to compensate for missing frames. Another major bug that was discovered and fixed was that sometimes the time step was set to a value that caused it to make a copy of the next frame. This would cause the appearance of faux-dupes that appeared right after another.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
-npad, --no-paddingoption to discard duplicate frames that are padded at the end of video segments. This is useful for creating smoother transitions between subregions at the expense of having a video with an unexpected duration.