Store Datatypes in database #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbainter
commented
Apr 17, 2024
|
|
||
| def create_datatype(name): | ||
| def create_datatype(datatype_object): | ||
| name = datatype_object.name | ||
| return { | ||
| 'id': '_'.join(name.split()), |
There was a problem hiding this comment.
I can follow up with a PR to start using actual IDs here; there's some JS that will need to be updated too
lisad
approved these changes
Apr 18, 2024
| @@ -88,3 +88,7 @@ class QueryLog(BaseModel): | |||
| datatype = models.CharField(max_length=30) | |||
| source = models.TextField(max_length=100) | |||
| destination = models.TextField(max_length=100) | |||
|
|
|||
| class DataType(BaseModel): | |||
| name = models.CharField(max_length=30) | |||
There was a problem hiding this comment.
It seems fine for the moment for the articles table NOT to have a foreign key to this one. WE can always change that in a migration later if we want the tables to link to each other and ensure integrity of the data type names. So I agree with this approach at least util we find need to enforce the dependency or follow the foreignkey relationship.
alexbainter
force-pushed
the
alex-77-datatype-population
branch
from
2474b13
to
bfd44e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77.
Follow-up steps (future PRs):