Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how context should interact with downcasting #32

Closed
dtolnay opened this issue Oct 22, 2019 · 1 comment · Fixed by #34
Closed

Figure out how context should interact with downcasting #32

dtolnay opened this issue Oct 22, 2019 · 1 comment · Fixed by #34

Comments

@dtolnay
Copy link
Owner

dtolnay commented Oct 22, 2019

For example if we have:

let e = fs::read("/...").context(ReadFailed).unwrap_err();
match e.downcast_ref::<ReadFailed>() {

should this downcast succeed or fail?

@dtolnay
Copy link
Owner Author

dtolnay commented Oct 22, 2019

For that matter, should e.downcast_ref::<io::Error>() succeed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant