Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/ directory is incompatible with "cargo vendor" #17

Closed
sayrer opened this issue Jan 24, 2020 · 1 comment
Closed

cmd/ directory is incompatible with "cargo vendor" #17

sayrer opened this issue Jan 24, 2020 · 1 comment
Labels
cargo Issues affecting Cargo-based use of cxx

Comments

@sayrer
Copy link
Contributor

sayrer commented Jan 24, 2020

I don't think cargo vendor is picking up the workspace members in Cargo.toml.

An approach that does work is a bin target. This is what cbindgen does:
https://github.com/eqrion/cbindgen/blob/ac1a7d47e87658cf36cb7e56edad7fa5f935dddd/Cargo.toml#L35

cargo vendor is something cargo-raze depends on to generate Bazel build files. If this issue were fixed, I believe the separate command would work well in a Bazel build.
@sayrer
Copy link
Contributor Author

sayrer commented Jan 24, 2020

I got this to work by specifying "cxxbridge-cmd-0.1.2" separately.

@sayrer sayrer closed this as completed Jan 24, 2020
@dtolnay dtolnay added the cargo Issues affecting Cargo-based use of cxx label Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cargo Issues affecting Cargo-based use of cxx
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sayrer @dtolnay